Re: [Qemu-ppc] [PATCH] target-ppc: Init dcache and icache size for e500 user mode

[Scott Wood]

On 04/12/2012 11:59 AM, Andreas Färber wrote:
> Am 10.04.2012 22:04, schrieb Meador Inge:
>> commit f7aa558396dd0f6b7a2b22c05cb503c655854102 pulled the dcache and icache
>> line size initialization inside of a '#if !defined(CONFIG_USER_ONLY)' block.
>> This is not correct because instructions like 'dcbz' need the dcache size
>> initialized even for user mode.
>>
>> Signed-off-by: Meador Inge <address@hidden>
> 
> Looks okay and compiles,
> 
> Reviewed-by: Andreas Färber <address@hidden>
> 
> Scott, are you planning to review this e500 patch? Or should I go ahead
> and apply?

I'm OK with it, though it may make more sense for USER_ONLY to just pick
an arbitrary cache line size (probably 32) than to try to imitate a
specific core.

-Scott