[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 03/58] spapr: make irq customizable via qdev
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH 03/58] spapr: make irq customizable via qdev |
Date: |
Thu, 15 Sep 2011 13:15:29 +1000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Sep 14, 2011 at 10:42:27AM +0200, Alexander Graf wrote:
> From: Paolo Bonzini <address@hidden>
>
> This also lets the user see the irq in "info qtree".
Um.. I'm a bit confused by this one. The previous patch comment
implies it's a preparation for this, but then you add the new irq
property to the BusInfo, rather than to the macro that goes into the
DeviceInfos. Why does this one go in the bus, rather than the device?
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> Cc: Alexander Graf <address@hidden>
> Cc: David Gibson <address@hidden>
> Signed-off-by: Alexander Graf <address@hidden>
> ---
> hw/spapr_vio.c | 8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/hw/spapr_vio.c b/hw/spapr_vio.c
> index ba2e1c1..0546ccb 100644
> --- a/hw/spapr_vio.c
> +++ b/hw/spapr_vio.c
> @@ -52,6 +52,10 @@
> static struct BusInfo spapr_vio_bus_info = {
> .name = "spapr-vio",
> .size = sizeof(VIOsPAPRBus),
> + .props = (Property[]) {
> + DEFINE_PROP_UINT32("irq", VIOsPAPRDevice, vio_irq_num, 0), \
> + DEFINE_PROP_END_OF_LIST(),
> + },
> };
>
> VIOsPAPRDevice *spapr_vio_find_by_reg(VIOsPAPRBus *bus, uint32_t reg)
> @@ -604,7 +608,9 @@ static int spapr_vio_busdev_init(DeviceState *qdev,
> DeviceInfo *qinfo)
> }
>
> dev->qdev.id = id;
> - dev->vio_irq_num = bus->irq++;
> + if (!dev->vio_irq_num) {
> + dev->vio_irq_num = bus->irq++;
> + }
> dev->qirq = spapr_find_qirq(spapr, dev->vio_irq_num);
>
> rtce_init(dev);
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
- [Qemu-ppc] [PULL 00/58] ppc patch queue 2011-09-14, Alexander Graf, 2011/09/14
- [Qemu-ppc] [PATCH 57/58] PPC: Fix heathrow PIC to use little endian MMIO, Alexander Graf, 2011/09/14
- [Qemu-ppc] [PATCH 55/58] ppc: move ADB stuff from ppc_mac.h to adb.h, Alexander Graf, 2011/09/14
- [Qemu-ppc] [PATCH 45/58] ppc: booke206: add "info tlb" support, Alexander Graf, 2011/09/14
- [Qemu-ppc] [PATCH 22/58] PPC: E500: Update freqs for all CPUs, Alexander Graf, 2011/09/14
- [Qemu-ppc] [PATCH 08/58] PPC: Set MPIC IDE for IPI to 0, Alexander Graf, 2011/09/14
- [Qemu-ppc] [PATCH 15/58] PPC: bamboo: Move host fdt copy to target, Alexander Graf, 2011/09/14
- [Qemu-ppc] [PATCH 19/58] PPC: bamboo: Use kvm api for freq and clock frequencies, Alexander Graf, 2011/09/14
- [Qemu-ppc] [PATCH 03/58] spapr: make irq customizable via qdev, Alexander Graf, 2011/09/14
- Re: [Qemu-ppc] [PATCH 03/58] spapr: make irq customizable via qdev,
David Gibson <=
- [Qemu-ppc] [PATCH 10/58] PPC: MPIC: Fix CI bit definitions, Alexander Graf, 2011/09/14
- [Qemu-ppc] [PATCH 48/58] pseries: Implement hcall-bulk hypervisor interface, Alexander Graf, 2011/09/14
- [Qemu-ppc] [PATCH 21/58] PPC: KVM: Add stubs for kvm helper functions, Alexander Graf, 2011/09/14
- [Qemu-ppc] [PATCH 09/58] PPC: MPIC: Remove read functionality for WO registers, Alexander Graf, 2011/09/14
- [Qemu-ppc] [PATCH 12/58] PPC: E500: create multiple envs, Alexander Graf, 2011/09/14
- [Qemu-ppc] [PATCH 16/58] PPC: KVM: Add generic function to read host clockfreq, Alexander Graf, 2011/09/14
- [Qemu-ppc] [PATCH 42/58] pseries: use macro for firmware filename, Alexander Graf, 2011/09/14
- [Qemu-ppc] [PATCH 14/58] device tree: add nop_node, Alexander Graf, 2011/09/14