[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v11 02/20] gdbstub: Implement deatch (D pkt) wit
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v11 02/20] gdbstub: Implement deatch (D pkt) with new infra |
Date: |
Mon, 27 May 2019 09:58:23 +0100 |
User-agent: |
mu4e 1.3.2; emacs 26.1 |
Alex Bennée <address@hidden> writes:
> Alex Bennée <address@hidden> writes:
>
>> Jon Doron <address@hidden> writes:
>>
>>> Signed-off-by: Jon Doron <address@hidden>
>>
>> Reviewed-by: Alex Bennée <address@hidden>
>
> Hmm although I bisected to this patch which fails on:
>
> 09:49 address@hidden/x86_64 [linux.git/address@hidden >gdb
> ./builds/arm64/vmlinux -x ~/lsrc/qemu.git/tests/guest-debug/test-gdbstub.py
<snip>
> Connecting to remote
> 0x0000000040000000 in ?? ()
> Checking we can step the first few instructions
> warning: Invalid remote reply:
<snip>
>>> }
>>> +
>>> + if (cmd_parser) {
>>> + /* helper will respond */
>>> + process_string_cmd(s, NULL, line_buf, cmd_parser, 1);
>>> + } else {
>>> + /* unknown command, empty respone */
>>> + put_packet(s, "");
>>> + }
>>> +
We can't default to this empty response until we have converted the
table otherwise we get strangeness and double responses.
>>> return RS_IDLE;
>>> }
--
Alex Bennée
- [Qemu-devel] [PATCH v11 00/20] gdbstub: Refactor command packets handler, Jon Doron, 2019/05/24
- [Qemu-devel] [PATCH v11 04/20] gdbstub: Implement continue (c pkt) with new infra, Jon Doron, 2019/05/24
- [Qemu-devel] [PATCH v11 06/20] gdbstub: Implement set_thread (H pkt) with new infra, Jon Doron, 2019/05/24
- [Qemu-devel] [PATCH v11 05/20] gdbstub: Implement continue with signal (C pkt) with new infra, Jon Doron, 2019/05/24
- [Qemu-devel] [PATCH v11 03/20] gdbstub: Implement thread_alive (T pkt) with new infra, Jon Doron, 2019/05/24
- [Qemu-devel] [PATCH v11 08/20] gdbstub: Implement set register (P pkt) with new infra, Jon Doron, 2019/05/24
- [Qemu-devel] [PATCH v11 07/20] gdbstub: Implement breakpoint commands (Z/z pkt) with new infra, Jon Doron, 2019/05/24
- [Qemu-devel] [PATCH v11 01/20] gdbstub: Add infrastructure to parse cmd packets, Jon Doron, 2019/05/24
- [Qemu-devel] [PATCH v11 09/20] gdbstub: Implement get register (p pkt) with new infra, Jon Doron, 2019/05/24
- [Qemu-devel] [PATCH v11 11/20] gdbstub: Implement read memory (m pkt) with new infra, Jon Doron, 2019/05/24