[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] qemu-common: Move tcg_enabled() etc. to sys
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/4] qemu-common: Move tcg_enabled() etc. to sysemu/tcg.h |
|
Date: |
Thu, 23 May 2019 14:38:41 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/23/19 10:35 AM, Markus Armbruster wrote:
> Other accelerators have their own headers: sysemu/hax.h, sysemu/hvf.h,
> sysemu/kvm.h, sysemu/whpx.h. Only tcg_enabled() & friends sit in
> qemu-common.h. This necessitates inclusion of qemu-common.h into
> headers, which is against the rules spelled out in qemu-common.h's
> file comment.
>
> Move tcg_enabled() & friends into their own header sysemu/tcg.h, and
> adjust #include directives.
>
> Cc: Richard Henderson <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH 0/4] Cleanups around qemu-common.h, Markus Armbruster, 2019/05/23
- [Qemu-devel] [PATCH 2/4] qemu-common: Move qemu_isalnum() etc. to qemu/ctype.h, Markus Armbruster, 2019/05/23
- [Qemu-devel] [PATCH 1/4] qemu-common: Move tcg_enabled() etc. to sysemu/tcg.h, Markus Armbruster, 2019/05/23
- Re: [Qemu-devel] [PATCH 1/4] qemu-common: Move tcg_enabled() etc. to sysemu/tcg.h,
Richard Henderson <=
- [Qemu-devel] [PATCH 4/4] Include qemu-common.h exactly where needed, Markus Armbruster, 2019/05/23
- [Qemu-devel] [PATCH 3/4] Include qemu/module.h where needed, drop it from qemu-common.h, Markus Armbruster, 2019/05/23