Re: [Qemu-devel] [PATCH 0/2] network announce; interface selection

[Dr. David Alan Gilbert]

* Laine Stump (address@hidden) wrote:
> On 5/23/19 10:58 AM, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <address@hidden>
> > 
> > Laine asked for some extra features on the network announce support;
> > this is the first one of them.
> > It allows you to send an announce on a subset of the interfaces.
> > 
> > Note since we've still only got one timer, if you start one announce
> > on an interface and then you start a second announce on another
> > interface, the first one gets cancelled even if it's part way through.
> > [That's the other feature Laine would like, but I need to think about
> > that a bit more.
> 
> I have a question without trying to read/understand the code: Does the
> restricted interface list persist to future self-announces? (e.g. one that
> is internally initiated by qemu) Or does it only apply to the current new
> self-announce? (Hopefully the latter)

Only to the manually triggered self-announce, not to the ones
generated by migration.

Dave

> > 
> > Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> > 
> > 
> > Dr. David Alan Gilbert (2):
> >    net/announce: Allow optional list of interfaces
> >    net/announce: Add HMP optional interface list
> > 
> >   hmp-commands.hx        |  6 ++++--
> >   hmp.c                  | 38 +++++++++++++++++++++++++++++++++++++-
> >   include/net/announce.h |  2 +-
> >   net/announce.c         | 39 ++++++++++++++++++++++++++++++++-------
> >   net/trace-events       |  2 +-
> >   qapi/net.json          |  8 +++++---
> >   6 files changed, 80 insertions(+), 15 deletions(-)
> > 
> 
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK