[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC] hw/core/bus.c: Only the main system bus can have
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [RFC] hw/core/bus.c: Only the main system bus can have no parent |
Date: |
Thu, 23 May 2019 16:32:07 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Peter Maydell <address@hidden> writes:
> On Thu, 23 May 2019 at 13:09, Markus Armbruster <address@hidden> wrote:
>> Registering qbus_reset_all_fn() in main() is kind of ugly, but it works.
>> There's a comment pointing out it's ugly. Right now it's a TODO
>> comment, which maybe expresses more hope for cleanup than there really
>> is. I'd leave it alone anyway.
>
> ...so after this long thread, are we at a conclusion?
> I think my view is that the patch-as-sent needs to be
> revised to also fix bus_unparent() but is otherwise OK.
Yup. You can add my
Reviewed-by: Markus Armbruster <address@hidden>
to it then
- Re: [Qemu-devel] [RFC] hw/core/bus.c: Only the main system bus can have no parent, (continued)
- Re: [Qemu-devel] [RFC] hw/core/bus.c: Only the main system bus can have no parent, Markus Armbruster, 2019/05/16
- Re: [Qemu-devel] [RFC] hw/core/bus.c: Only the main system bus can have no parent, Peter Maydell, 2019/05/16
- Re: [Qemu-devel] [RFC] hw/core/bus.c: Only the main system bus can have no parent, Damien Hedde, 2019/05/20
- Re: [Qemu-devel] [RFC] hw/core/bus.c: Only the main system bus can have no parent, Markus Armbruster, 2019/05/21
- Re: [Qemu-devel] [RFC] hw/core/bus.c: Only the main system bus can have no parent, Peter Maydell, 2019/05/21
- Re: [Qemu-devel] [RFC] hw/core/bus.c: Only the main system bus can have no parent, Markus Armbruster, 2019/05/23
- Re: [Qemu-devel] [RFC] hw/core/bus.c: Only the main system bus can have no parent, Peter Maydell, 2019/05/23
- Re: [Qemu-devel] [RFC] hw/core/bus.c: Only the main system bus can have no parent, Markus Armbruster, 2019/05/23
- Re: [Qemu-devel] [RFC] hw/core/bus.c: Only the main system bus can have no parent, Peter Maydell, 2019/05/23
- Re: [Qemu-devel] [RFC] hw/core/bus.c: Only the main system bus can have no parent, Damien Hedde, 2019/05/23
- Re: [Qemu-devel] [RFC] hw/core/bus.c: Only the main system bus can have no parent,
Markus Armbruster <=