[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 5/7] hmp: Handle virtio-pmem when printing memory de
From: |
Pankaj Gupta |
Subject: |
[Qemu-devel] [PATCH 5/7] hmp: Handle virtio-pmem when printing memory device infos |
Date: |
Thu, 23 May 2019 15:54:47 +0530 |
From: David Hildenbrand <address@hidden>
Print the memory device info just like for PCDIMM/NVDIMM.
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
---
hmp.c | 27 +++++++++++++++------------
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/hmp.c b/hmp.c
index 92941142af..e1866bc7f1 100644
--- a/hmp.c
+++ b/hmp.c
@@ -2650,6 +2650,7 @@ void hmp_info_memory_devices(Monitor *mon, const QDict
*qdict)
Error *err = NULL;
MemoryDeviceInfoList *info_list = qmp_query_memory_devices(&err);
MemoryDeviceInfoList *info;
+ VirtioPMEMDeviceInfo *vpi;
MemoryDeviceInfo *value;
PCDIMMDeviceInfo *di;
@@ -2659,19 +2660,9 @@ void hmp_info_memory_devices(Monitor *mon, const QDict
*qdict)
if (value) {
switch (value->type) {
case MEMORY_DEVICE_INFO_KIND_DIMM:
- di = value->u.dimm.data;
- break;
-
case MEMORY_DEVICE_INFO_KIND_NVDIMM:
- di = value->u.nvdimm.data;
- break;
-
- default:
- di = NULL;
- break;
- }
-
- if (di) {
+ di = value->type == MEMORY_DEVICE_INFO_KIND_DIMM ?
+ value->u.dimm.data : value->u.nvdimm.data;
monitor_printf(mon, "Memory device [%s]: \"%s\"\n",
MemoryDeviceInfoKind_str(value->type),
di->id ? di->id : "");
@@ -2684,6 +2675,18 @@ void hmp_info_memory_devices(Monitor *mon, const QDict
*qdict)
di->hotplugged ? "true" : "false");
monitor_printf(mon, " hotpluggable: %s\n",
di->hotpluggable ? "true" : "false");
+ break;
+ case MEMORY_DEVICE_INFO_KIND_VIRTIO_PMEM:
+ vpi = value->u.virtio_pmem.data;
+ monitor_printf(mon, "Memory device [%s]: \"%s\"\n",
+ MemoryDeviceInfoKind_str(value->type),
+ vpi->id ? vpi->id : "");
+ monitor_printf(mon, " memaddr: 0x%" PRIx64 "\n",
vpi->memaddr);
+ monitor_printf(mon, " size: %" PRIu64 "\n", vpi->size);
+ monitor_printf(mon, " memdev: %s\n", vpi->memdev);
+ break;
+ default:
+ g_assert_not_reached();
}
}
}
--
2.14.5
- [Qemu-devel] [PATCH 0/7] Qemu virtio pmem device, Pankaj Gupta, 2019/05/23
- [Qemu-devel] [PATCH 2/7] virtio-pci: Allow to specify additional interfaces for the base type, Pankaj Gupta, 2019/05/23
- [Qemu-devel] [PATCH 1/7] virtio-pmem: add virtio device, Pankaj Gupta, 2019/05/23
- [Qemu-devel] [PATCH 3/7] virtio-pmem: sync linux headers, Pankaj Gupta, 2019/05/23
- [Qemu-devel] [PATCH 4/7] virtio-pci: Proxy for virtio-pmem, Pankaj Gupta, 2019/05/23
- [Qemu-devel] [PATCH 5/7] hmp: Handle virtio-pmem when printing memory device infos,
Pankaj Gupta <=
- [Qemu-devel] [PATCH 6/7] numa: Handle virtio-pmem in NUMA stats, Pankaj Gupta, 2019/05/23
- [Qemu-devel] [PATCH 7/7] pc: Support for virtio-pmem-pci, Pankaj Gupta, 2019/05/23