[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/5] qemu-bridge-helper: Fix misuse of isspace()
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 1/5] qemu-bridge-helper: Fix misuse of isspace() |
Date: |
Wed, 22 May 2019 15:47:22 +0200 |
parse_acl_file() passes char values to isspace(). Undefined behavior
when the value is negative. Not a security issue, because the
characters come from trusted $prefix/etc/qemu/bridge.conf and the
files it includes.
Furthermore, isspace()'s locale-dependence means qemu-bridge-helper
uses the user's locale for parsing $prefix/etc/bridge.conf. Feels
wrong.
Use g_ascii_isspace() instead. This fixes the undefined behavior, and
makes parsing of $prefix/etc/bridge.conf locale-independent.
Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
---
qemu-bridge-helper.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/qemu-bridge-helper.c b/qemu-bridge-helper.c
index 5396fbfbb6..f9940deefd 100644
--- a/qemu-bridge-helper.c
+++ b/qemu-bridge-helper.c
@@ -75,7 +75,7 @@ static int parse_acl_file(const char *filename, ACLList
*acl_list)
char *ptr = line;
char *cmd, *arg, *argend;
- while (isspace(*ptr)) {
+ while (g_ascii_isspace(*ptr)) {
ptr++;
}
@@ -99,12 +99,12 @@ static int parse_acl_file(const char *filename, ACLList
*acl_list)
*arg = 0;
arg++;
- while (isspace(*arg)) {
+ while (g_ascii_isspace(*arg)) {
arg++;
}
argend = arg + strlen(arg);
- while (arg != argend && isspace(*(argend - 1))) {
+ while (arg != argend && g_ascii_isspace(*(argend - 1))) {
argend--;
}
*argend = 0;
--
2.17.2
- [Qemu-devel] [PULL 0/5] Miscellaneous patches for 2019-05-22, Markus Armbruster, 2019/05/22
- [Qemu-devel] [PULL 1/5] qemu-bridge-helper: Fix misuse of isspace(),
Markus Armbruster <=
- [Qemu-devel] [PULL 5/5] cutils: Simplify how parse_uint() checks for whitespace, Markus Armbruster, 2019/05/22
- [Qemu-devel] [PULL 3/5] gdbstub: Reject invalid RLE repeat counts, Markus Armbruster, 2019/05/22
- [Qemu-devel] [PULL 4/5] gdbstub: Fix misuse of isxdigit(), Markus Armbruster, 2019/05/22
- [Qemu-devel] [PULL 2/5] tests/vhost-user-bridge: Fix misuse of isdigit(), Markus Armbruster, 2019/05/22
- Re: [Qemu-devel] [PULL 0/5] Miscellaneous patches for 2019-05-22, Peter Maydell, 2019/05/23