[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v2 21/36] pci: Simplify pci_bus_is_root()
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PULL v2 21/36] pci: Simplify pci_bus_is_root() |
Date: |
Wed, 22 May 2019 16:11:21 +1000 |
User-agent: |
Mutt/1.11.4 (2019-03-13) |
On Mon, May 20, 2019 at 07:11:09PM -0400, Michael S. Tsirkin wrote:
> From: David Gibson <address@hidden>
>
> pci_bus_is_root() currently relies on a method in the PCIBusClass.
> But it's always known if a PCI bus is a root bus when we create it, so
> using a dynamic method is overkill.
>
> This replaces it with an IS_ROOT bit in a new flags field, which is set on
> root buses and otherwise clear. As a bonus this removes the special
> is_root logic from pci_expander_bridge, since it already creates its bus
> as a root bus.
>
> Signed-off-by: David Gibson <address@hidden>
> Reviewed-by: Marcel Apfelbaum <address@hidden>
> Reviewed-by: Peter Xu <address@hidden>
> Reviewed-by: Greg Kurz <address@hidden>
> Message-Id: <address@hidden>
Michael, is there a particular reason this and the mmcfg patch went
in, but not the later patches in my PCI-E cleanup series?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-devel] [PULL 15/37] do not call vhost_net_cleanup() on running net from char user event, (continued)
- [Qemu-devel] [PULL 15/37] do not call vhost_net_cleanup() on running net from char user event, Michael S. Tsirkin, 2019/05/16
- [Qemu-devel] [PULL 16/37] hw/arm/virt-acpi-build: remove unnecessary variable mcfg_start, Michael S. Tsirkin, 2019/05/16
- [Qemu-devel] [PULL 17/37] i386, acpi: remove mcfg_ prefix in AcpiMcfgInfo members, Michael S. Tsirkin, 2019/05/16
- [Qemu-devel] [PULL 18/37] hw/arm/virt-acpi-build: pass AcpiMcfgInfo to build_mcfg(), Michael S. Tsirkin, 2019/05/16
- [Qemu-devel] [PULL 19/37] hw/acpi: Consolidate build_mcfg to pci.c, Michael S. Tsirkin, 2019/05/16
- [Qemu-devel] [PULL 20/37] libvhost-user: fix bad vu_log_write, Michael S. Tsirkin, 2019/05/16
- [Qemu-devel] [PULL 21/37] pcie: Remove redundant test in pcie_mmcfg_data_{read, write}(), Michael S. Tsirkin, 2019/05/16
- [Qemu-devel] [PULL 22/37] pci: Simplify pci_bus_is_root(), Michael S. Tsirkin, 2019/05/16
- Re: [Qemu-devel] [PULL v2 21/36] pci: Simplify pci_bus_is_root(),
David Gibson <=
- Re: [Qemu-devel] [PULL 00/37] pci, pc, virtio: features, fixes, Peter Maydell, 2019/05/16
- Re: [Qemu-devel] [PULL 00/37] pci, pc, virtio: features, fixes, Philippe Mathieu-Daudé, 2019/05/16
- Re: [Qemu-devel] [PULL 00/37] pci, pc, virtio: features, fixes, Philippe Mathieu-Daudé, 2019/05/16
- Re: [Qemu-devel] [PULL 00/37] pci, pc, virtio: features, fixes, Wei Yang, 2019/05/16
- Re: [Qemu-devel] [PULL 00/37] pci, pc, virtio: features, fixes, Philippe Mathieu-Daudé, 2019/05/17
- Re: [Qemu-devel] [PULL 00/37] pci, pc, virtio: features, fixes, Thomas Huth, 2019/05/17
- Re: [Qemu-devel] [PULL 00/37] pci, pc, virtio: features, fixes, Philippe Mathieu-Daudé, 2019/05/17
- Re: [Qemu-devel] [PULL 00/37] pci, pc, virtio: features, fixes, Wei Yang, 2019/05/16
- Re: [Qemu-devel] [PULL 00/37] pci, pc, virtio: features, fixes, Wei Yang, 2019/05/16
- Re: [Qemu-devel] [PULL 00/37] pci, pc, virtio: features, fixes, Philippe Mathieu-Daudé, 2019/05/17