[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 1/9] qapi/block-core: add option for io_urin
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC PATCH 1/9] qapi/block-core: add option for io_uring |
Date: |
Tue, 21 May 2019 19:39:26 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/21/19 6:52 PM, Aarushi Mehta wrote:
> Signed-off-by: Aarushi Mehta <address@hidden>
Sparse on the details. The subject line says what, but without a 'why'
for how io_uring is different from existing aio options, it's hard to
see why I'd want to use it. Do you have any benchmark numbers?
> ---
> qapi/block-core.json | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 7ccbfff9d0..116995810a 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2776,11 +2776,12 @@
> #
> # @threads: Use qemu's thread pool
> # @native: Use native AIO backend (only Linux and Windows)
> +# @io_uring: Use linux io_uring
Missing a '(since 4.1)' tag.
> #
> # Since: 2.9
> ##
> { 'enum': 'BlockdevAioOptions',
> - 'data': [ 'threads', 'native' ] }
> + 'data': [ 'threads', 'native','io_uring' ] }
Missing space after ',' (not essential, but matching style is nice).
Should the new element be defined conditionally, so that introspection
only sees the new enum member when compiled for Linux?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC PATCH 7/9] blockdev: accept io_uring as option, (continued)
- [Qemu-devel] [RFC PATCH 7/9] blockdev: accept io_uring as option, Aarushi Mehta, 2019/05/21
- [Qemu-devel] [RFC PATCH 6/9] block/io_uring: implements interfaces for io_uring, Aarushi Mehta, 2019/05/21
- [Qemu-devel] [RFC PATCH 5/9] util/asyn: add aio interfaces for io_uring, Aarushi Mehta, 2019/05/21
- [Qemu-devel] [RFC PATCH 4/9] stubs: add aio interface stubs for io_uring, Aarushi Mehta, 2019/05/21
- [Qemu-devel] [RFC PATCH 3/9] include/block: declare interfaces for io_uring, Aarushi Mehta, 2019/05/21
- [Qemu-devel] [RFC PATCH 1/9] qapi/block-core: add option for io_uring, Aarushi Mehta, 2019/05/21
- Re: [Qemu-devel] [RFC PATCH 1/9] qapi/block-core: add option for io_uring,
Eric Blake <=
- [Qemu-devel] [RFC PATCH 2/9] block/block: add BDRV flag for io_uring, Aarushi Mehta, 2019/05/21
- Re: [Qemu-devel] [RFC PATCH 0/9] Add support for io_uring, no-reply, 2019/05/21
- Re: [Qemu-devel] [RFC PATCH 0/9] Add support for io_uring, Stefan Hajnoczi, 2019/05/22