[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v10 06/20] gdbstub: Implement set_thread (H pkt) wit
From: |
Jon Doron |
Subject: |
[Qemu-devel] [PATCH v10 06/20] gdbstub: Implement set_thread (H pkt) with new infra |
Date: |
Tue, 21 May 2019 12:59:34 +0300 |
Signed-off-by: Jon Doron <address@hidden>
---
gdbstub.c | 83 +++++++++++++++++++++++++++++++++++--------------------
1 file changed, 53 insertions(+), 30 deletions(-)
diff --git a/gdbstub.c b/gdbstub.c
index f74a30da03..129a47230f 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1546,6 +1546,51 @@ static void handle_cont_with_sig(GdbCmdContext *gdb_ctx,
void *user_ctx)
gdb_continue(gdb_ctx->s);
}
+static void handle_set_thread(GdbCmdContext *gdb_ctx, void *user_ctx)
+{
+ CPUState *cpu;
+
+ if (gdb_ctx->num_params != 2) {
+ put_packet(gdb_ctx->s, "E22");
+ return;
+ }
+
+ if (gdb_ctx->params[1].thread_id.kind == GDB_READ_THREAD_ERR) {
+ put_packet(gdb_ctx->s, "E22");
+ return;
+ }
+
+ if (gdb_ctx->params[1].thread_id.kind != GDB_ONE_THREAD) {
+ put_packet(gdb_ctx->s, "OK");
+ return;
+ }
+
+ cpu = gdb_get_cpu(gdb_ctx->s, gdb_ctx->params[1].thread_id.pid,
+ gdb_ctx->params[1].thread_id.tid);
+ if (!cpu) {
+ put_packet(gdb_ctx->s, "E22");
+ return;
+ }
+
+ /*
+ * Note: This command is deprecated and modern gdb's will be using the
+ * vCont command instead.
+ */
+ switch (gdb_ctx->params[0].opcode) {
+ case 'c':
+ gdb_ctx->s->c_cpu = cpu;
+ put_packet(gdb_ctx->s, "OK");
+ break;
+ case 'g':
+ gdb_ctx->s->g_cpu = cpu;
+ put_packet(gdb_ctx->s, "OK");
+ break;
+ default:
+ put_packet(gdb_ctx->s, "E22");
+ break;
+ }
+}
+
static int gdb_handle_packet(GDBState *s, const char *line_buf)
{
CPUState *cpu;
@@ -1559,7 +1604,6 @@ static int gdb_handle_packet(GDBState *s, const char
*line_buf)
char thread_id[16];
uint8_t *registers;
target_ulong addr, len;
- GDBThreadIdKind thread_kind;
const GdbCmdParseEntry *cmd_parser = NULL;
trace_gdbstub_io_command(line_buf);
@@ -1822,35 +1866,14 @@ static int gdb_handle_packet(GDBState *s, const char
*line_buf)
put_packet(s, "E22");
break;
case 'H':
- type = *p++;
-
- thread_kind = read_thread_id(p, &p, &pid, &tid);
- if (thread_kind == GDB_READ_THREAD_ERR) {
- put_packet(s, "E22");
- break;
- }
-
- if (thread_kind != GDB_ONE_THREAD) {
- put_packet(s, "OK");
- break;
- }
- cpu = gdb_get_cpu(s, pid, tid);
- if (cpu == NULL) {
- put_packet(s, "E22");
- break;
- }
- switch (type) {
- case 'c':
- s->c_cpu = cpu;
- put_packet(s, "OK");
- break;
- case 'g':
- s->g_cpu = cpu;
- put_packet(s, "OK");
- break;
- default:
- put_packet(s, "E22");
- break;
+ {
+ static const GdbCmdParseEntry set_thread_cmd_desc = {
+ .handler = handle_set_thread,
+ .cmd = "H",
+ .cmd_startswith = 1,
+ .schema = "o.t0"
+ };
+ cmd_parser = &set_thread_cmd_desc;
}
break;
case 'T':
--
2.21.0
- [Qemu-devel] [PATCH v10 00/20] gdbstub: Refactor command packets handler, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 01/20] gdbstub: Add infrastructure to parse cmd packets, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 03/20] gdbstub: Implement thread_alive (T pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 02/20] gdbstub: Implement deatch (D pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 04/20] gdbstub: Implement continue (c pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 06/20] gdbstub: Implement set_thread (H pkt) with new infra,
Jon Doron <=
- [Qemu-devel] [PATCH v10 05/20] gdbstub: Implement continue with signal (C pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 07/20] gdbstub: Implement breakpoint commands (Z/z pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 08/20] gdbstub: Implement set register (P pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 09/20] gdbstub: Implement get register (p pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 10/20] gdbstub: Implement write memory (M pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 12/20] gdbstub: Implement write all registers (G pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 13/20] gdbstub: Implement read all registers (g pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 11/20] gdbstub: Implement read memory (m pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 14/20] gdbstub: Implement file io (F pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 19/20] gdbstub: Clear unused variables in gdb_handle_packet, Jon Doron, 2019/05/21