[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] blockdev: fix missed target unref for drive-
|
From: |
John Snow |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] blockdev: fix missed target unref for drive-backup |
|
Date: |
Mon, 20 May 2019 18:32:40 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/13/19 11:06 AM, John Snow wrote:
> If the bitmap can't be used for whatever reason, we skip putting down
> the reference. Fix that.
>
> In practice, this means that if you attempt to gracefully exit QEMU
> after a backup command being rejected, bdrv_close_all will fail and
> tell you some unpleasant things via assert().
>
> Reported-by: aihua liang <address@hidden>
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1703916
> Signed-off-by: John Snow <address@hidden>
> Reviewed-by: Kevin Wolf <address@hidden>
(I assume this can go through either Kevin or Max's tree?)