[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 5/8] migration: Add multifd-compress paramete
From: |
Wei Yang |
Subject: |
Re: [Qemu-devel] [PATCH v3 5/8] migration: Add multifd-compress parameter |
Date: |
Mon, 20 May 2019 21:32:33 +0000 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Wed, May 15, 2019 at 02:15:41PM +0200, Juan Quintela wrote:
>diff --git a/qapi/migration.json b/qapi/migration.json
>index 9cfbaf8c6c..8ec1944b7a 100644
>--- a/qapi/migration.json
>+++ b/qapi/migration.json
>@@ -482,6 +482,19 @@
> ##
> { 'command': 'query-migrate-capabilities', 'returns':
> ['MigrationCapabilityStatus']}
>
>+##
>+# @MultifdCompress:
>+#
>+# An enumeration of multifd compression.
>+#
>+# @none: no compression.
>+#
>+# Since: 4.1
>+#
>+##
>+{ 'enum': 'MultifdCompress',
>+ 'data': [ 'none' ] }
>+
> ##
> # @MigrationParameter:
> #
>@@ -580,6 +593,9 @@
> # @max-cpu-throttle: maximum cpu throttle percentage.
> # Defaults to 99. (Since 3.1)
> #
>+# @multifd-compress: Which compression method to use.
>+# Defaults to none. (Since 4.1)
>+#
> # Since: 2.4
> ##
> { 'enum': 'MigrationParameter',
>@@ -592,7 +608,7 @@
> 'downtime-limit', 'x-checkpoint-delay', 'block-incremental',
> 'multifd-channels',
> 'xbzrle-cache-size', 'max-postcopy-bandwidth',
>- 'max-cpu-throttle' ] }
>+ 'max-cpu-throttle', 'multifd-compress' ] }
>
> ##
> # @MigrateSetParameters:
>@@ -682,6 +698,9 @@
> # @max-cpu-throttle: maximum cpu throttle percentage.
> # The default value is 99. (Since 3.1)
> #
>+# @multifd-compress: Which compression method to use.
>+# Defaults to none. (Since 4.1)
>+#
> # Since: 2.4
> ##
> # TODO either fuse back into MigrationParameters, or make
>@@ -707,7 +726,8 @@
> '*multifd-channels': 'int',
> '*xbzrle-cache-size': 'size',
> '*max-postcopy-bandwidth': 'size',
>- '*max-cpu-throttle': 'int' } }
>+ '*max-cpu-throttle': 'int',
A tab at the beginning, it would be better to fix this :-)
>+ '*multifd-compress': 'MultifdCompress' } }
>
> ##
> # @migrate-set-parameters:
>@@ -817,6 +837,9 @@
> # Defaults to 99.
> # (Since 3.1)
> #
>+# @multifd-compress: Which compression method to use.
>+# Defaults to none. (Since 4.1)
>+#
> # Since: 2.4
> ##
> { 'struct': 'MigrationParameters',
>@@ -840,7 +863,8 @@
> '*multifd-channels': 'uint8',
> '*xbzrle-cache-size': 'size',
> '*max-postcopy-bandwidth': 'size',
>- '*max-cpu-throttle':'uint8'} }
>+ '*max-cpu-throttle': 'uint8',
>+ '*multifd-compress': 'MultifdCompress' } }
>
> ##
> # @query-migrate-parameters:
--
Wei Yang
Help you, Help me
- [Qemu-devel] [PATCH v3 2/8] migration-test: rename parameter to parameter_int, (continued)
- [Qemu-devel] [PATCH v3 2/8] migration-test: rename parameter to parameter_int, Juan Quintela, 2019/05/15
- [Qemu-devel] [PATCH v3 3/8] tests: Add migration multifd test, Juan Quintela, 2019/05/15
- [Qemu-devel] [PATCH v3 4/8] migration-test: introduce functions to handle string parameters, Juan Quintela, 2019/05/15
- [Qemu-devel] [PATCH v3 5/8] migration: Add multifd-compress parameter, Juan Quintela, 2019/05/15
- [Qemu-devel] [PATCH v3 6/8] migration: Make none operations into its own structure, Juan Quintela, 2019/05/15
- [Qemu-devel] [PATCH v3 7/8] multifd: Add zlib compression support, Juan Quintela, 2019/05/15
- [Qemu-devel] [PATCH v3 8/8] multifd: rest of zlib compression, Juan Quintela, 2019/05/15
- Re: [Qemu-devel] [PATCH v3 0/8] WIP: Multifd compression support, Wei Yang, 2019/05/20