Re: [Qemu-devel] [PATCH v2 3/8] target/sparc: Define an enumeration for accessing env->regwptr

[Richard Henderson]

On 5/14/19 10:44 PM, Philippe Mathieu-Daudé wrote:
>> +/* Windowed register indexes.  */
>> +enum {
>> +    WREG_O0,
>> +    WREG_O1,
>> +    WREG_O2,
>> +    WREG_O3,
>> +    WREG_O4,
>> +    WREG_O5,
>> +    WREG_O6,
>> +    WREG_O7,
>> +
>> +    WREG_L0,
>> +    WREG_L1,
>> +    WREG_L2,
>> +    WREG_L3,
>> +    WREG_L4,
>> +    WREG_L5,
>> +    WREG_L6,
>> +    WREG_L7,
>> +
>> +    WREG_I0,
>> +    WREG_I1,
>> +    WREG_I2,
>> +    WREG_I3,
>> +    WREG_I4,
>> +    WREG_I5,
>> +    WREG_I6,
>> +    WREG_I7,
> 
> I'd feel safer if you initialize those enums (better safe than sorry!).

What are you suggesting?  This is how C works, and always has...


r~