Re: [Qemu-devel] [PATCH] spapr: Print out extra hints when CAS negotiation of interrupt mode fails

[Greg Kurz]

On Thu, 16 May 2019 10:22:26 +0200
Cédric Le Goater <address@hidden> wrote:

> On 5/16/19 9:45 AM, Satheesh Rajendran wrote:
> > On Thu, May 16, 2019 at 09:36:57AM +0200, Greg Kurz wrote:  
> >> Let's suggest to the user how the machine should be configured to allow
> >> the guest to boot successfully.
> >>
> >> Suggested-by: Satheesh Rajendran <address@hidden>
> >> Signed-off-by: Greg Kurz <address@hidden>
> >> ---
> >>  hw/ppc/spapr_hcall.c |    4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)  
> > 
> > Reviewed-and-Tested-by: Satheesh Rajendran <address@hidden>  
> 
> you should use two different tags. I don't think patchwork understand
> compounds.
> 
> C. 
> 

It doesn't indeed.

$ pwclient view 1100396 | grep Reviewed
$
 
> > 2019-05-16T07:42:43.018771Z qemu-system-ppc64: Guest requested unavailable 
> > interrupt mode (XICS), either don't set the ic-mode machine property or try 
> > ic-mode=xics or ic-mode=dual
> > 2019-05-16 07:42:43.394+0000: shutting down, reason=crashed
> >   
> >>
> >> diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c
> >> index 63a55614b83d..aae9fd2b3e6d 100644
> >> --- a/hw/ppc/spapr_hcall.c
> >> +++ b/hw/ppc/spapr_hcall.c
> >> @@ -1646,12 +1646,12 @@ static target_ulong 
> >> h_client_architecture_support(PowerPCCPU *cpu,
> >>       */
> >>      if (guest_xive) {
> >>          if (spapr->irq->ov5 == SPAPR_OV5_XIVE_LEGACY) {
> >> -            error_report("Guest requested unavailable interrupt mode 
> >> (XIVE)");
> >> +            error_report("Guest requested unavailable interrupt mode 
> >> (XIVE), try the ic-mode=xive or ic-mode=dual machine property");
> >>              exit(EXIT_FAILURE);
> >>          }
> >>      } else {
> >>          if (spapr->irq->ov5 == SPAPR_OV5_XIVE_EXPLOIT) {
> >> -            error_report("Guest requested unavailable interrupt mode 
> >> (XICS)");
> >> +            error_report("Guest requested unavailable interrupt mode 
> >> (XICS), either don't set the ic-mode machine property or try ic-mode=xics 
> >> or ic-mode=dual");
> >>              exit(EXIT_FAILURE);
> >>          }
> >>      }
> >>  
> >   
>