[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/4] net: fix assertion failure when ipv6-pre
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/4] net: fix assertion failure when ipv6-prefixlen is not a number |
Date: |
Thu, 16 May 2019 10:26:15 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Stefano Garzarella <address@hidden> writes:
> If 'ipv6-prefixlen' is not a number, the current behaviour
> produces an assertion failure:
> $ qemu-system-x86_64 -net user,ipv6-net=feca::0/a
> qemu-system-x86_64: qemu/util/qemu-option.c:1175: qemu_opts_foreach:
> Assertion `!errp || !*errp' failed.
> Aborted (core dumped)
>
> This patch fixes it, jumping to the end of the function when
> 'ipv6-prefixlen' is not a number, and printing the more friendly
> message:
> $ qemu-system-x86_64 -net user,ipv6-net=feca::0/a
> qemu-system-x86_64: Parameter 'ipv6-prefixlen' expects a number
>
> Signed-off-by: Stefano Garzarella <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>