[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v7 04/24] crypto: Use O_CLOEXEC in qcrypto_random_in
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH v7 04/24] crypto: Use O_CLOEXEC in qcrypto_random_init |
Date: |
Tue, 14 May 2019 12:16:33 -0700 |
Avoids leaking the /dev/urandom fd into any child processes.
Reviewed-by: Laurent Vivier <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
crypto/random-platform.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/crypto/random-platform.c b/crypto/random-platform.c
index 260b64564d..6df40744c7 100644
--- a/crypto/random-platform.c
+++ b/crypto/random-platform.c
@@ -42,9 +42,9 @@ int qcrypto_random_init(Error **errp)
#else
/* TBD perhaps also add support for BSD getentropy / Linux
* getrandom syscalls directly */
- fd = open("/dev/urandom", O_RDONLY);
+ fd = open("/dev/urandom", O_RDONLY | O_CLOEXEC);
if (fd == -1 && errno == ENOENT) {
- fd = open("/dev/random", O_RDONLY);
+ fd = open("/dev/random", O_RDONLY | O_CLOEXEC);
}
if (fd < 0) {
--
2.17.1
- [Qemu-devel] [PATCH v7 00/24] Add qemu_getrandom and ARMv8.5-RNG etc, Richard Henderson, 2019/05/14
- [Qemu-devel] [PATCH v7 01/24] build: Link user-only with crypto-rng-obj-y, Richard Henderson, 2019/05/14
- [Qemu-devel] [PATCH v7 02/24] crypto: Reverse code blocks in random-platform.c, Richard Henderson, 2019/05/14
- [Qemu-devel] [PATCH v7 03/24] crypto: Do not fail for EINTR during qcrypto_random_bytes, Richard Henderson, 2019/05/14
- [Qemu-devel] [PATCH v7 04/24] crypto: Use O_CLOEXEC in qcrypto_random_init,
Richard Henderson <=
- [Qemu-devel] [PATCH v7 05/24] crypto: Use getrandom for qcrypto_random_bytes, Richard Henderson, 2019/05/14
- [Qemu-devel] [PATCH v7 07/24] ui/vnc: Split out authentication_failed, Richard Henderson, 2019/05/14
- [Qemu-devel] [PATCH v7 06/24] crypto: Change the qcrypto_random_bytes buffer type to void*, Richard Henderson, 2019/05/14
- [Qemu-devel] [PATCH v7 09/24] util: Add qemu_guest_getrandom and associated routines, Richard Henderson, 2019/05/14
- [Qemu-devel] [PATCH v7 08/24] ui/vnc: Use gcrypto_random_bytes for start_auth_vnc, Richard Henderson, 2019/05/14
- [Qemu-devel] [PATCH v7 12/24] linux-user: Call qcrypto_random_init if not using -seed, Richard Henderson, 2019/05/14
- [Qemu-devel] [PATCH v7 10/24] cpus: Initialize pseudo-random seeds for all guest cpus, Richard Henderson, 2019/05/14
- [Qemu-devel] [PATCH v7 13/24] linux-user: Use qemu_guest_getrandom_nofail for AT_RANDOM, Richard Henderson, 2019/05/14
- [Qemu-devel] [PATCH v7 11/24] linux-user: Initialize pseudo-random seeds for all guest cpus, Richard Henderson, 2019/05/14
- [Qemu-devel] [PATCH v7 15/24] linux-user: Remove srand call, Richard Henderson, 2019/05/14