[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 05/16] migration: savevm: fix error code with migrati
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[Qemu-devel] [PULL 05/16] migration: savevm: fix error code with migration blockers |
Date: |
Tue, 14 May 2019 19:34:43 +0100 |
From: Cole Robinson <address@hidden>
The only caller that checks the error code is looking for != 0,
so returning false is incorrect.
Fixes: 5aaac467938 "migration: savevm: consult migration blockers"
Signed-off-by: Cole Robinson <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
---
migration/savevm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/savevm.c b/migration/savevm.c
index 587fec8ce2..81a9a2ef30 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -2542,7 +2542,7 @@ int save_snapshot(const char *name, Error **errp)
AioContext *aio_context;
if (migration_is_blocked(errp)) {
- return false;
+ return ret;
}
if (!replay_can_snapshot()) {
--
2.21.0
- [Qemu-devel] [PULL 00/16] migration queue, Dr. David Alan Gilbert (git), 2019/05/14
- [Qemu-devel] [PULL 01/16] migration: comment VMSTATE_UNUSED*() properly, Dr. David Alan Gilbert (git), 2019/05/14
- [Qemu-devel] [PULL 02/16] migration: not necessary to check ops again, Dr. David Alan Gilbert (git), 2019/05/14
- [Qemu-devel] [PULL 03/16] migration: remove not used field xfer_limit, Dr. David Alan Gilbert (git), 2019/05/14
- [Qemu-devel] [PULL 04/16] vmstate: check subsection_found is enough, Dr. David Alan Gilbert (git), 2019/05/14
- [Qemu-devel] [PULL 05/16] migration: savevm: fix error code with migration blockers,
Dr. David Alan Gilbert (git) <=
- [Qemu-devel] [PULL 06/16] migration/colo.c: Remove redundant input parameter, Dr. David Alan Gilbert (git), 2019/05/14
- [Qemu-devel] [PULL 07/16] migration/colo.h: Remove obsolete codes, Dr. David Alan Gilbert (git), 2019/05/14
- [Qemu-devel] [PULL 08/16] qemu-option.hx: Update missed parameter for colo-compare, Dr. David Alan Gilbert (git), 2019/05/14
- [Qemu-devel] [PULL 09/16] migration/ram.c: start of migration_bitmap_sync_range is always 0, Dr. David Alan Gilbert (git), 2019/05/14
- [Qemu-devel] [PULL 10/16] migration: update comments of migration bitmap, Dr. David Alan Gilbert (git), 2019/05/14
- [Qemu-devel] [PULL 11/16] migration/savevm: remove duplicate check of migration_is_blocked, Dr. David Alan Gilbert (git), 2019/05/14
- [Qemu-devel] [PULL 12/16] migration/savevm: load_header before load_setup, Dr. David Alan Gilbert (git), 2019/05/14
- [Qemu-devel] [PULL 13/16] migration/savevm: wrap into qemu_loadvm_state_header(), Dr. David Alan Gilbert (git), 2019/05/14
- [Qemu-devel] [PULL 14/16] migration: Fix use-after-free during process exit, Dr. David Alan Gilbert (git), 2019/05/14
- [Qemu-devel] [PULL 15/16] migration/ram.c: fix typos in comments, Dr. David Alan Gilbert (git), 2019/05/14