[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] rng-builtin: add an RNG backend that uses qe
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH v2] rng-builtin: add an RNG backend that uses qemu_guest_getrandom() |
Date: |
Fri, 10 May 2019 12:36:40 +0100 |
User-agent: |
Mutt/1.11.4 (2019-03-13) |
On Fri, May 10, 2019 at 12:26:37PM +0200, Laurent Vivier wrote:
> Add a new RNG backend using QEMU builtin getrandom function.
>
> It can be created and used with something like:
>
> ... -object rng-builtin,id=rng0 -device virtio-rng,rng=rng0 ...
>
> Reviewed-by: Richard Henderson <address@hidden>
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
>
> Notes:
> This patch applies on top of
> "[PATCH v5 00/24] Add qemu_getrandom and ARMv8.5-RNG etc"
> Based-on: address@hidden
>
> v2: Update qemu-options.hx
> describe the new backend and specify virtio-rng uses the
> rng-random by default (do we want to change this?)
Yeah, I think we could change the default backend, as it won't affect
migration in any way
>
> backends/Makefile.objs | 2 +-
> backends/rng-builtin.c | 56 ++++++++++++++++++++++++++++++++++++++++++
> qemu-options.hx | 10 +++++++-
> 3 files changed, 66 insertions(+), 2 deletions(-)
> create mode 100644 backends/rng-builtin.c
Reviewed-by: Daniel P. Berrangé <address@hidden>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|