[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tests: qpci_unplug_acpi_device_test() should no
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH] tests: qpci_unplug_acpi_device_test() should not rely on global_qtest |
|
Date: |
Fri, 10 May 2019 11:39:30 +0100 |
|
User-agent: |
Mutt/1.11.4 (2019-03-13) |
On Wed, May 08, 2019 at 04:32:09PM +0200, Thomas Huth wrote:
> libqos functions should not use functions that require global_qtest to
> be set, since such library functions could also be used by tests that
> deal with multiple test states. Add a parameter to this function to
> explicitly specify the test state.
>
> Signed-off-by: Thomas Huth <address@hidden>
> ---
> tests/e1000e-test.c | 4 +++-
> tests/ivshmem-test.c | 9 ++++++---
> tests/libqos/pci-pc.c | 10 +++++-----
> tests/libqos/pci.h | 2 +-
> tests/virtio-blk-test.c | 3 ++-
> tests/virtio-net-test.c | 4 +++-
> tests/virtio-rng-test.c | 5 ++++-
> 7 files changed, 24 insertions(+), 13 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature