[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 22/23] tests/qemu-iotests: re-format output t
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v1 22/23] tests/qemu-iotests: re-format output to for make check-block |
Date: |
Fri, 10 May 2019 06:45:03 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 09/05/2019 18.59, Alex Bennée wrote:
> This attempts to clean-up the output to better match the output of the
> rest of the QEMU check system. This includes:
>
> - formatting as " TEST iotest: nnn"
> - calculating time diff at the end
> - only dumping config on failure
>
> Signed-off-by: Alex Bennée <address@hidden>
> Message-Id: <address@hidden>
> ---
> tests/qemu-iotests/check | 101 +++++++++++++++++++++++----------------
> 1 file changed, 61 insertions(+), 40 deletions(-)
[...]
> -cat <<EOF
> -QEMU -- "$QEMU_PROG" $QEMU_OPTIONS
> -QEMU_IMG -- "$QEMU_IMG_PROG" $QEMU_IMG_OPTIONS
> -QEMU_IO -- "$QEMU_IO_PROG" $QEMU_IO_OPTIONS
> -QEMU_NBD -- "$QEMU_NBD_PROG" $QEMU_NBD_OPTIONS
> -IMGFMT -- $FULL_IMGFMT_DETAILS
> -IMGPROTO -- $IMGPROTO
> -PLATFORM -- $FULL_HOST_DETAILS
> -TEST_DIR -- $TEST_DIR
> -SOCKET_SCM_HELPER -- $SOCKET_SCM_HELPER
> -
> -EOF
> +if ! $pretty; then
> + _full_env_details
> +fi
>
> seq="check"
[...]
> @@ -852,9 +869,13 @@ do
> #
> if $err
> then
> + _report_test_result $seq "FAILED $reason"
> + _full_env_details
I'd suggest to wrap the _full_env_details with a "if $pretty" statement,
otherwise the env will be printed out twice, one time at the beginning,
and one time in case of an error.
> bad="$bad $seq"
> n_bad=$(expr $n_bad + 1)
> quick=false
> + else
> + _report_test_result $seq "$results"
> fi
> [ -f $seq.notrun ] || try=$(expr $try + 1)
>
>
Thomas
- [Qemu-devel] [PATCH v1 21/23] tests/qemu-iotests/group: Re-use the "auto" group for tests that can always run, (continued)
- [Qemu-devel] [PATCH v1 21/23] tests/qemu-iotests/group: Re-use the "auto" group for tests that can always run, Alex Bennée, 2019/05/09
- [Qemu-devel] [PATCH v1 16/23] tests/qemu-iotests/005: Add a sanity check for large sparse file support, Alex Bennée, 2019/05/09
- [Qemu-devel] [PATCH v1 23/23] tests: Run the iotests during "make check" again, Alex Bennée, 2019/05/09
- [Qemu-devel] [PATCH v1 20/23] tests/qemu-iotests: Remove the "_supported_os Linux" line from many tests, Alex Bennée, 2019/05/09
- [Qemu-devel] [PATCH v1 22/23] tests/qemu-iotests: re-format output to for make check-block, Alex Bennée, 2019/05/09
- Re: [Qemu-devel] [PATCH v1 22/23] tests/qemu-iotests: re-format output to for make check-block,
Thomas Huth <=