[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/6] fsdev: Move some types definition to qemu-f
From: |
Greg Kurz |
Subject: |
Re: [Qemu-devel] [PATCH 3/6] fsdev: Move some types definition to qemu-fsdev.c |
Date: |
Thu, 9 May 2019 15:21:32 +0200 |
On Wed, 8 May 2019 10:28:03 +0200
Thomas Huth <address@hidden> wrote:
> On 07/05/2019 10.45, Greg Kurz wrote:
> > It would make sense for these types to be defined in a header file if
> > we had an API for fsdrivers to register themselves. In practice, we
> > only have three of them and it is very unlikely we add new ones since
> > the future of file sharing between host and guest is the upcoming
> > virtio-fs.
> >
> > Move the types to qemu-fsdev.c instead since they are only used there.
> >
> > Signed-off-by: Greg Kurz <address@hidden>
> > ---
> > fsdev/qemu-fsdev.c | 23 +++++++++++++++++++++++
> > fsdev/qemu-fsdev.h | 24 ------------------------
> > 2 files changed, 23 insertions(+), 24 deletions(-)
>
> Reviewed-by: Thomas Huth <address@hidden>
Applied to https://github.com/gkurz/qemu/commits/9p-next
Cheers,
--
Greg
- [Qemu-devel] [PATCH 0/6] fsdev/virtfs: Assorted cleanups and fixes, Greg Kurz, 2019/05/07
- [Qemu-devel] [PATCH 1/6] fsdev: Drop unused extern declaration, Greg Kurz, 2019/05/07
- [Qemu-devel] [PATCH 2/6] fsdev: Drop unused opaque field, Greg Kurz, 2019/05/07
- [Qemu-devel] [PATCH 3/6] fsdev: Move some types definition to qemu-fsdev.c, Greg Kurz, 2019/05/07
- [Qemu-devel] [PATCH 4/6] fsdev: Error out when unsupported option is passed, Greg Kurz, 2019/05/07
- [Qemu-devel] [PATCH 5/6] vl: Deprecate -virtfs_synth, Greg Kurz, 2019/05/07
- [Qemu-devel] [PATCH 6/6] virtfs: Fix documentation of -fsdev and -virtfs, Greg Kurz, 2019/05/07