[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Deprecate Python 2 support
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH] Deprecate Python 2 support |
Date: |
Wed, 08 May 2019 14:50:00 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Daniel P. Berrangé <address@hidden> writes:
> On Tue, May 07, 2019 at 12:38:14PM +0200, Kevin Wolf wrote:
>> Am 03.05.2019 um 21:37 hat Eduardo Habkost geschrieben:
>> > Python 2 will reach end of life in January 1 2020. Declare it as
>> > deprecated.
>> >
>> > Signed-off-by: Eduardo Habkost <address@hidden>
>> > ---
>> > configure | 8 ++++++++
>> > qemu-deprecated.texi | 8 ++++++++
>> > 2 files changed, 16 insertions(+)
>> >
>> > diff --git a/configure b/configure
>> > index 5b183c2e39..50385061ed 100755
>> > --- a/configure
>> > +++ b/configure
>> > @@ -6461,6 +6461,14 @@ if test "$supported_os" = "no"; then
>> > echo "us upstream at address@hidden"
>> > fi
>> >
>> > +# Note that if the Python conditional here evaluates True we will exit
>> > +# with status 1 which is a shell 'false' value.
>> > +if ! $python -c 'import sys; sys.exit(sys.version_info < (3,0))'; then
>> > + echo
>> > + echo "WARNING: Python 2 support is deprecated" >&2
>> > + echo "WARNING: Python 3 will be required for building future versions
>> > of QEMU" >&2
>> > +fi
>>
>> While it's clear that we want to get rid of Python 2, did we actually
>> discuss how to decide what the new minimum Python version is? I don't
>> think any major distribution uses 3.0, which was released in 2008, so
>> this doesn't seem to make a lot of sense to me as the new minimum.
Good point.
>> Currently, 3.6 seems to be a commonly available version. It looks like
>> Debian stable is at 3.5 still, though it might become oldstable before
>> the next QEMU release. Do we need to support anything older than that?
>
> Per our support build platform doc, the oldest distros we care about will
> be RHEL-7 and Debian Jessie. Except we can drop Jessie 2 years after
> Stretch was released. IOW, we can drop Jessie in June this year, which
> is before our next releasee. So we don't need to care about the 3.4
> version in Jessie.
>
> RHEL-7 doesn't have py3 at all in standard distros, but it can be obtained
> via software collections and this has 3.6
>
> Debian Strech has 3.5.3, so 3.5 looks like our min viable version.
Eduardo, care to update configure accordingly?