[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 1/5] hw/misc: Add the STM32F4xx Sysconfig dev
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH v1 1/5] hw/misc: Add the STM32F4xx Sysconfig device |
|
Date: |
Fri, 3 May 2019 14:40:33 +0100 |
On Thu, 2 May 2019 at 06:40, Alistair Francis <address@hidden> wrote:
>
> Signed-off-by: Alistair Francis <address@hidden>
> +static void stm32f4xx_syscfg_set_irq(void *opaque, int irq, int level)
> +{
> + STM32F4xxSyscfgState *s = opaque;
> + int icrreg = irq / 4;
> + int startbit = (irq & 3) * 4;
> + uint8_t config = config = irq / 16;;
Stray double-semicolon.
Otherwise
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM