[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/3] edu: mmio: allow 64-bit access in read d
From: |
Jiri Slaby |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/3] edu: mmio: allow 64-bit access in read dispatch |
Date: |
Fri, 3 May 2019 11:12:52 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 22. 04. 19, 16:11, Li Qiang wrote:
> The edu spec says when address >= 0x80, the MMIO area can
> be accessed by 64-bit.
>
> Signed-off-by: Li Qiang <address@hidden>
> ---
> Change since v2:
> Fix an error per Phillippe's advice
>
> hw/misc/edu.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/hw/misc/edu.c b/hw/misc/edu.c
> index 65fc32b928..33de05141f 100644
> --- a/hw/misc/edu.c
> +++ b/hw/misc/edu.c
> @@ -185,7 +185,11 @@ static uint64_t edu_mmio_read(void *opaque, hwaddr addr,
> unsigned size)
> EduState *edu = opaque;
> uint64_t val = ~0ULL;
>
> - if (size != 4) {
> + if (addr < 0x80 && size != 4) {
> + return val;
> + }
> +
> + if (addr >= 0x80 && size != 4 && size != 8) {
> return val;
> }
Good catch, thanks.
--
js
suse labs
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v3 2/3] edu: mmio: allow 64-bit access in read dispatch,
Jiri Slaby <=