Re: [Qemu-devel] [PATCH v2 1/3] leon3: add a little bootloader

[Mark Cave-Ayland]

On 03/05/2019 09:18, KONRAD Frederic wrote:

> Hi Mark,
> 
>>>>       }
>>>
>>> I think this patch is basically okay, however if you don't supply both a 
>>> kernel and
>>> bios then you get the slightly enigmatic message below:
>>>
>>> $ ./qemu-system-sparc -M leon3_generic
>>> qemu-system-sparc: Can't read bios image (null)
>>>
>>> Perhaps add a define for LEON3_BIOS_FILENAME and return that if filename == 
>>> NULL to
>>> give a better error message?
>>
>> Okay I see there is already a PROM_FILENAME that exists and can be used here.
> 
> I think we already have this behavior without this patch. Should this be fixed
> in an other patch?

Hi Frederic,

Yes, that probably makes sense here since it will make rebases slightly easier, 
plus
gives people the option to backport if required.


ATB,

Mark.