Re: [Qemu-devel] [PATCH v4 00/15] tests: acpi: add UEFI (ARM) testing support

[Wei Xu]

Hi Ignor,

On 5/2/2019 3:51 PM, Igor Mammedov wrote:
> Changelog:
>   - from v3:
>       * reshaffle patch order a bit
>       * move out acpi_parse_rsdp_table() hunk to
>           "tests: acpi: make pointer to RSDP  64bit"
>         where it belongs
>       * move acpi_fetch_rsdp_table(s/uint32_t addr/uint64_t addr/) to
>         this patch where it belongs from:
>            "tests: acpi: make RSDT test routine handle XSDT"
>       * dropping Reviewed-bys due to acpi_fetch_table() change
>         introduced by earlier patch:
>           "tests: acpi: make acpi_fetch_table() take size of fetched table 
> pointer"
>       * update [8/15] commit message to point to commit which introduced
>         signature_guid value.
>       * get rid of test_acpi_rsdp_address() in [9/15]
>       * added new patch
>          tests: acpi: allow to override default accelerator
>       * force arm/virt test to use TCG accelerator
>   - from v2:
>       * rebase on top current master (with UEFI blobs merged)
>       * added a Makefile rule to include bios-tables-test to aarch64 tests by
>         default into 11/13 (kept Reviewed-bys)
>       * other trivial fixes and cleanups (see per patch changelogs)
>    
>   - from v1:
>       * rebase on top
>          (1) [PATCH for-4.1 v3 00/12] bundle edk2 platform firmware  with QEMU
>         let me to drop edk2 images and drop Makefile magic to unpack them,
>         Laszlo's series conveniently does it all for me.
>       * use new path/names for firmware images as supplied by [1]
>       * reorder patches a bit so that UEFI parts would go after generic 
> changes
> 
> Series adds support for ACPI tables located above 4G. It adds 64-bit handling
> necessary for testing arm/virt board (i.e. might be not complete wrt spec) and
> uses recently merged UEFI (AVMF) firmware/test disk image which provides
> an entry point[1] for fetching ACPI tables (RSDP pointer).
> 
> Git tree for testing:
>    https://github.com/imammedo/qemu.git acpi_arm_tests_v4
> 
> Ref to previos vesrsion:
>    [PATCH v3 00/13] tests: acpi: add UEFI (ARM) testing support
>    https://www.mail-archive.com/address@hidden/msg612679.html
> 
> CC: Laszlo Ersek <address@hidden>
> CC: "Michael S. Tsirkin" <address@hidden>
> CC: Gonglei <address@hidden>
> CC: Philippe Mathieu-Daudé <address@hidden>
> CC: Shannon Zhao <address@hidden>
> CC: Wei Yang <address@hidden>
> CC: Andrew Jones <address@hidden>
> CC: Shameer Kolothum <address@hidden>
> CC: Ben Warren <address@hidden>
> CC: <address@hidden>
> CC: <address@hidden>
> CC: <address@hidden>
> CC: <address@hidden>
> 
> Igor Mammedov (15):
>   tests: acpi: rename acpi_parse_rsdp_table() into
>     acpi_fetch_rsdp_table()
>   tests: acpi: make acpi_fetch_table() take size of fetched table
>     pointer
>   tests: acpi: make RSDT test routine handle XSDT
>   tests: acpi: make pointer to RSDP 64bit
>   tests: acpi: fetch X_DSDT if pointer to DSDT is 0
>   tests: acpi: skip FACS table if board uses hw reduced ACPI profile
>   tests: acpi: move boot_sector_init() into x86 tests branch
>   tests: acpi: add acpi_find_rsdp_address_uefi() helper
>   tests: acpi: add a way to start tests with UEFI firmware
>   tests: acpi: ignore SMBIOS tests when UEFI firmware is used
>   tests: acpi: allow to override default accelerator
>   tests: add expected ACPI tables for arm/virt board
>   tests: acpi: add simple arm/virt testcase
>   tests: acpi: refactor rebuild-expected-aml.sh to dump ACPI tables for
>     a specified list of targets
>   tests: acpi: print error unable to dump ACPI table during rebuild
> 
>  tests/acpi-utils.h                      |   7 +-
>  tests/Makefile.include                  |   1 +
>  tests/acpi-utils.c                      |  68 +++++++++++----
>  tests/bios-tables-test.c                | 148 
> +++++++++++++++++++++++---------
>  tests/data/acpi/rebuild-expected-aml.sh |  23 +++--
>  tests/data/acpi/virt/APIC               | Bin 0 -> 168 bytes
>  tests/data/acpi/virt/DSDT               | Bin 0 -> 18476 bytes
>  tests/data/acpi/virt/FACP               | Bin 0 -> 268 bytes
>  tests/data/acpi/virt/GTDT               | Bin 0 -> 96 bytes
>  tests/data/acpi/virt/MCFG               | Bin 0 -> 60 bytes
>  tests/data/acpi/virt/SPCR               | Bin 0 -> 80 bytes
>  tests/vmgenid-test.c                    |   6 +-
>  12 files changed, 178 insertions(+), 75 deletions(-)
>  create mode 100644 tests/data/acpi/virt/APIC
>  create mode 100644 tests/data/acpi/virt/DSDT
>  create mode 100644 tests/data/acpi/virt/FACP
>  create mode 100644 tests/data/acpi/virt/GTDT
>  create mode 100644 tests/data/acpi/virt/MCFG
>  create mode 100644 tests/data/acpi/virt/SPCR
> 

Tested the series on the hisilicon D05 board(arm64 based), so FWIW:

Tested-by: Wei Xu <address@hidden>

Thanks!

Best Regards,
Wei