[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] arm: aspeed: Set SDRAM size
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] arm: aspeed: Set SDRAM size |
|
Date: |
Wed, 1 May 2019 07:07:00 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 4/30/19 11:18 PM, Joel Stanley wrote:
> mc->no_parallel = 1;
> + if (board->ram)
> + mc->default_ram_size = board->ram;
In addition to the braces, for which patchew will have sent you nag mail...
> + .ram = 256 << 20,
In <qemu/units.h> there are some defines to make this more readable as
.ram = 256 * MiB,
Otherwise,
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH] arm: aspeed: Set SDRAM size, Joel Stanley, 2019/05/01
- Re: [Qemu-devel] [PATCH] arm: aspeed: Set SDRAM size, no-reply, 2019/05/01
- Re: [Qemu-devel] [PATCH] arm: aspeed: Set SDRAM size, Andrew Jeffery, 2019/05/01
- Re: [Qemu-devel] [PATCH] arm: aspeed: Set SDRAM size, no-reply, 2019/05/01
- Re: [Qemu-devel] [PATCH] arm: aspeed: Set SDRAM size,
Richard Henderson <=
- Re: [Qemu-devel] [PATCH] arm: aspeed: Set SDRAM size, no-reply, 2019/05/01
- Re: [Qemu-devel] [PATCH] arm: aspeed: Set SDRAM size, Philippe Mathieu-Daudé, 2019/05/01
- Re: [Qemu-devel] [PATCH] arm: aspeed: Set SDRAM size, no-reply, 2019/05/01