qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-ppc] [RFC for-4.1 21/25] target/ppc: Style fixes


From: David Gibson
Subject: Re: [Qemu-devel] [Qemu-ppc] [RFC for-4.1 21/25] target/ppc: Style fixes for translate.c
Date: Tue, 26 Mar 2019 11:21:12 +1100
User-agent: Mutt/1.11.3 (2019-02-01)

On Mon, Mar 25, 2019 at 10:56:34AM +0100, Greg Kurz wrote:
> On Fri, 22 Mar 2019 11:15:40 +1100
> David Gibson <address@hidden> wrote:
> 
> > Signed-off-by: David Gibson <address@hidden>
[snip]
> > @@ -2916,10 +2955,11 @@ static void gen_stmw(DisasContext *ctx)
> >  /***                    Integer load and store strings                     
> > ***/
> >  
> >  /* lswi */
> > -/* PowerPC32 specification says we must generate an exception if
> > - * rA is in the range of registers to be loaded.
> > - * In an other hand, IBM says this is valid, but rA won't be loaded.
> > - * For now, I'll follow the spec...
> > +/*
> > + * PowerPC32 specification says we must generate an exception if rA is
> > + * in the range of registers to be loaded.  In an other hand, IBM says
> > + * this is valid, but rA won't be loaded.  For now, I'll follow the
> > + * spec...
> >   */
> 
> Merge with the preceding comment ?

Actually, I think I'll leave it.  The one-liner serves a different
purpose and has a different format to the block below.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]