Re: [Qemu-devel] [PATCH for-4.1 00/35] tcg: Move the softmmu tlb to CPUNegativeOffsetState

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH for-4.1 00/35] tcg: Move the softmmu tlb to 
CPUNegativeOffsetState
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
d1700d8105 tcg/arm: Use LDRD to load tlb mask+table
6fea5a55f5 tcg/aarch64: Use LDP to load tlb mask+table
c58058146b cpu: Remove CPU_COMMON
baea823f37 cpu: Move the softmmu tlb to CPUNegativeOffsetState
ea517fda54 cpu: Move icount_decr to CPUNegativeOffsetState
5a9eb19210 cpu: Introduce CPUNegativeOffsetState
e6935da753 cpu: Move ENV_OFFSET to exec/gen-icount.h
9e9500704a target/xtensa: Use env_cpu, env_archcpu
7465342e22 target/unicore32: Use env_cpu, env_archcpu
83ee4b5455 target/tricore: Use env_cpu
f387cedb3b target/tilegx: Use env_cpu
5d95e6b049 target/sparc: Use env_cpu, env_archcpu
1bbc50511a target/sh4: Use env_cpu, env_archcpu
2b66e665c0 target/s390x: Use env_cpu, env_archcpu
de2caf9480 target/riscv: Use env_cpu, env_archcpu
16d5ab98ff target/ppc: Use env_cpu, env_archcpu
e351a3dec1 target/openrisc: Use env_cpu, env_archcpu
f0af08e73f target/nios2: Use env_cpu, env_archcpu
4608db3d65 target/moxie: Use env_cpu, env_archcpu
d5e7d2e3f4 target/mips: Use env_cpu, env_archcpu
4333c56896 target/microblaze: Use env_cpu, env_archcpu
faae7b3fc7 target/m68k: Use env_cpu, env_archcpu
40082bea4d target/lm32: Use env_cpu, env_archcpu
9f01e6f34b target/i386: Use env_cpu, env_archcpu
4cebac8128 target/hppa: Use env_cpu, env_archcpu
3a51d8c72c target/cris: Use env_cpu, env_archcpu
d34fb24a61 target/arm: Use env_cpu, env_archcpu
815a46f2d4 target/alpha: Use env_cpu, env_archcpu
2014d9c385 cpu: Introduce env_archcpu
aaa0acc53e cpu: Replace ENV_GET_CPU with env_cpu
85d89e6f2b cpu: Define ArchCPU
d0b5a94824 cpu: Define CPUArchState with typedef
b034922803 tcg: Create struct CPUTLB
763b65c081 tcg: Split out target/arch/cpu-param.h
4cb187a892 tcg: Fold CPUTLBWindow into CPUTLBDesc

=== OUTPUT BEGIN ===
1/35 Checking commit 4cb187a892e5 (tcg: Fold CPUTLBWindow into CPUTLBDesc)
2/35 Checking commit 763b65c08108 (tcg: Split out target/arch/cpu-param.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#55: 
new file mode 100644

WARNING: Block comments use a leading /* on a separate line
#356: FILE: target/i386/cpu-param.h:4:
+/* ??? This is really 48 bits, sign-extended, but the only thing

WARNING: Block comments use * on subsequent lines
#357: FILE: target/i386/cpu-param.h:5:
+/* ??? This is really 48 bits, sign-extended, but the only thing
+   accessible to userland with bit 48 set is the VSYSCALL, and that

WARNING: Block comments use a trailing */ on a separate line
#358: FILE: target/i386/cpu-param.h:6:
+   is handled via other mechanisms.  */

WARNING: Block comments use a leading /* on a separate line
#465: FILE: target/m68k/cpu-param.h:2:
+/* Coldfire Linux uses 8k pages

ERROR: code indent should never use tabs
#1023: FILE: target/sh4/cpu-param.h:2:
+#define TARGET_PAGE_BITS 12^I/* 4k */$

total: 1 errors, 5 warnings, 1030 lines checked

Patch 2/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/35 Checking commit b03492280352 (tcg: Create struct CPUTLB)
WARNING: line over 80 characters
#349: FILE: accel/tcg/cputlb.c:781:
+        env_tlb(env)->d[mmu_idx].viotlb[vidx] = 
env_tlb(env)->d[mmu_idx].iotlb[index];

total: 0 errors, 1 warnings, 677 lines checked

Patch 3/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/35 Checking commit d0b5a9482459 (cpu: Define CPUArchState with typedef)
5/35 Checking commit 85d89e6f2b8d (cpu: Define ArchCPU)
6/35 Checking commit aaa0acc53e5f (cpu: Replace ENV_GET_CPU with env_cpu)
WARNING: line over 80 characters
#1191: FILE: target/i386/hvf/x86_emu.c:412:
+        hvf_handle_io(env_cpu(env), DX(env), &RAX(env), 1, 
decode->operand_size, 1);

WARNING: line over 80 characters
#1204: FILE: target/i386/hvf/x86_emu.c:429:
+        hvf_handle_io(env_cpu(env), decode->op[0].val, &val, 0, 
decode->operand_size, 1);

WARNING: line over 80 characters
#1226: FILE: target/i386/hvf/x86_emu.c:487:
+    target_ulong addr = linear_addr_size(env_cpu(env), RDI(env), 
decode->addressing_size,

WARNING: line over 80 characters
#1233: FILE: target/i386/hvf/x86_emu.c:492:
+    vmx_write_mem(env_cpu(env), addr, env->hvf_emul->mmio_buf, 
decode->operand_size);

WARNING: line over 80 characters
#1243: FILE: target/i386/hvf/x86_emu.c:512:
+    vmx_read_mem(env_cpu(env), env->hvf_emul->mmio_buf, addr, 
decode->operand_size);

WARNING: line over 80 characters
#1271: FILE: target/i386/hvf/x86_emu.c:594:
+    addr = linear_addr_size(env_cpu(env), RDI(env), decode->addressing_size, 
R_ES);

WARNING: line over 80 characters
#1283: FILE: target/i386/hvf/x86_emu.c:617:
+    addr = linear_addr_size(env_cpu(env), RDI(env), decode->addressing_size, 
R_ES);

total: 0 errors, 7 warnings, 1318 lines checked

Patch 6/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/35 Checking commit 2014d9c38562 (cpu: Introduce env_archcpu)
8/35 Checking commit 815a46f2d450 (target/alpha: Use env_cpu, env_archcpu)
9/35 Checking commit d34fb24a61f8 (target/arm: Use env_cpu, env_archcpu)
10/35 Checking commit 3a51d8c72c9f (target/cris: Use env_cpu, env_archcpu)
ERROR: suspect code indent for conditional statements (24, 16)
#96: FILE: target/cris/op_helper.c:141:
                        if (tlb_v) {
+                tlb_flush_page(env_cpu(env), vaddr);

total: 1 errors, 0 warnings, 76 lines checked

Patch 10/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

11/35 Checking commit 4cebac812828 (target/hppa: Use env_cpu, env_archcpu)
12/35 Checking commit 9f01e6f34b4d (target/i386: Use env_cpu, env_archcpu)
13/35 Checking commit 40082bea4d7f (target/lm32: Use env_cpu, env_archcpu)
14/35 Checking commit faae7b3fc73c (target/m68k: Use env_cpu, env_archcpu)
15/35 Checking commit 4333c568969e (target/microblaze: Use env_cpu, env_archcpu)
16/35 Checking commit d5e7d2e3f4f4 (target/mips: Use env_cpu, env_archcpu)
17/35 Checking commit 4608db3d6541 (target/moxie: Use env_cpu, env_archcpu)
18/35 Checking commit f0af08e73fcd (target/nios2: Use env_cpu, env_archcpu)
19/35 Checking commit e351a3dec1bf (target/openrisc: Use env_cpu, env_archcpu)
20/35 Checking commit 16d5ab98ffbb (target/ppc: Use env_cpu, env_archcpu)
WARNING: line over 80 characters
#549: FILE: target/ppc/mmu_helper.c:741:
+        cpu_abort(env_cpu(env), "Little-endian regions are not supported by 
now\n");

WARNING: line over 80 characters
#616: FILE: target/ppc/mmu_helper.c:1454:
+            cpu_abort(env_cpu(env), "PowerPC in real mode do not do any 
translation\n");

WARNING: line over 80 characters
#1073: FILE: target/ppc/translate_init.inc.c:4849:
+        cpu_abort(env_cpu(env), "Unknown CPU: " TARGET_FMT_lx "\n", 
env->spr[SPR_PVR]);

WARNING: line over 80 characters
#1082: FILE: target/ppc/translate_init.inc.c:4873:
+        cpu_abort(env_cpu(env), "Unknown CPU: " TARGET_FMT_lx "\n", 
env->spr[SPR_PVR]);

total: 0 errors, 4 warnings, 1149 lines checked

Patch 20/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/35 Checking commit de2caf948058 (target/riscv: Use env_cpu, env_archcpu)
22/35 Checking commit 2b66e665c0c7 (target/s390x: Use env_cpu, env_archcpu)
23/35 Checking commit 1bbc50511a30 (target/sh4: Use env_cpu, env_archcpu)
24/35 Checking commit 5d95e6b0494c (target/sparc: Use env_cpu, env_archcpu)
25/35 Checking commit f387cedb3b98 (target/tilegx: Use env_cpu)
26/35 Checking commit 83ee4b5455dc (target/tricore: Use env_cpu)
27/35 Checking commit 7465342e22c8 (target/unicore32: Use env_cpu, env_archcpu)
28/35 Checking commit 9e9500704afd (target/xtensa: Use env_cpu, env_archcpu)
29/35 Checking commit e6935da75399 (cpu: Move ENV_OFFSET to exec/gen-icount.h)
30/35 Checking commit 5a9eb192102c (cpu: Introduce CPUNegativeOffsetState)
31/35 Checking commit ea517fda548e (cpu: Move icount_decr to 
CPUNegativeOffsetState)
ERROR: return is not a function, parentheses are not required
#206: FILE: cpus.c:240:
+    return (cpu->icount_budget -

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#381: 
new file mode 100644

WARNING: Block comments use a leading /* on a separate line
#482: FILE: qom/cpu-common.c:97:
+/* Resetting the IRQ comes from across the code base so we take the

WARNING: Block comments use a trailing */ on a separate line
#483: FILE: qom/cpu-common.c:98:
+ * BQL here if we need to.  cpu_interrupt assumes it is held.*/

WARNING: Block comments use a leading /* on a separate line
#568: FILE: qom/cpu-common.c:183:
+    /* If no extra check is required, QEMU watchpoint match can be considered

WARNING: Block comments use a leading /* on a separate line
#680: FILE: qom/cpu-common.c:295:
+    /* qdev_get_machine() can return something that's not TYPE_MACHINE

total: 1 errors, 5 warnings, 970 lines checked

Patch 31/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

32/35 Checking commit baea823f3758 (cpu: Move the softmmu tlb to 
CPUNegativeOffsetState)
ERROR: trailing whitespace
#202: FILE: tcg/i386/tcg-target.inc.c:1657:
+                         TLB_MASK_TABLE_OFS(mem_index) + $

ERROR: trailing whitespace
#207: FILE: tcg/i386/tcg-target.inc.c:1661:
+                         TLB_MASK_TABLE_OFS(mem_index) + $

total: 2 errors, 0 warnings, 395 lines checked

Patch 32/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

33/35 Checking commit c58058146b25 (cpu: Remove CPU_COMMON)
34/35 Checking commit 6fea5a55f568 (tcg/aarch64: Use LDP to load tlb mask+table)
35/35 Checking commit d1700d810526 (tcg/arm: Use LDRD to load tlb mask+table)
ERROR: code indent should never use tabs
#113: FILE: tcg/arm/tcg-target.inc.c:1289:
+^I^I        TCG_REG_R1, TCG_REG_R1, TCG_REG_R0, 0);$

ERROR: code indent should never use tabs
#118: FILE: tcg/arm/tcg-target.inc.c:1294:
+^I}$

total: 2 errors, 0 warnings, 133 lines checked

Patch 35/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden