Re: [Qemu-devel] [PULL 0/1] seccomp branch queue

[Peter Maydell]

On Wed, 20 Mar 2019 at 15:11, Eduardo Otubo <address@hidden> wrote:
>
> The following changes since commit 62a172e6a77d9072bb1a18f295ce0fcf4b90a4f2:
>
>   Update version for v4.0.0-rc0 release (2019-03-19 17:17:22 +0000)
>
> are available in the Git repository at:
>
>   https://github.com/otubo/qemu.git tags/pull-seccomp-20190320
>
> for you to fetch changes up to a25f1f63814c8ac5347a4d744c5bbad2702ef51c:
>
>   seccomp: don't kill process for resource control syscalls (2019-03-20 
> 16:05:02 +0100)
>
> ----------------------------------------------------------------
> pull-seccomp-20190320
>
> ----------------------------------------------------------------
> Daniel P. Berrangé (1):
>       seccomp: don't kill process for resource control syscalls

Hi; I'm afraid this doesn't build on all platforms:

On PPC64 and also on my x86-64 box:
/home/pm215/qemu/qemu-seccomp.c: In function ‘seccomp_start’:
/home/pm215/qemu/qemu-seccomp.c:181:9: error: implicit declaration of
function ‘qemu_seccomp_get_kill_action’
[-Werror=implicit-function-declaration]
         action = qemu_seccomp_get_kill_action(blacklist[i].set);
         ^
/home/pm215/qemu/qemu-seccomp.c:181:9: error: nested extern
declaration of ‘qemu_seccomp_get_kill_action’ [-Werror=nested-externs]
/home/pm215/qemu/qemu-seccomp.c: At top level:
/home/pm215/qemu/qemu-seccomp.c:124:17: error:
‘qemu_seccomp_get_action’ defined but not used
[-Werror=unused-function]
 static uint32_t qemu_seccomp_get_action(int set)
                 ^

I think this will fail to build anywhere where
CONFIG_SECCOMP is set, or am I missing something ?

thanks
-- PMM