[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/12] EDK2 Firmware roms
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PULL 00/12] EDK2 Firmware roms |
Date: |
Wed, 20 Mar 2019 15:58:07 +0000 |
On Wed, 20 Mar 2019 at 15:31, Laszlo Ersek <address@hidden> wrote:
>
> Hi Peter,
>
> On 03/19/19 10:22, Peter Maydell wrote:
> > On Mon, 18 Mar 2019 at 21:21, Philippe Mathieu-Daudé <address@hidden>
> > wrote:
> >>
> >> Hi Peter,
> >>
> >> Le dim. 17 mars 2019 23:02, Peter Maydell <address@hidden>
> >> a écrit :
> >>>
> >>> On Sun, 17 Mar 2019 at 20:29, Peter Maydell
> >>> <address@hidden> wrote:
> >>>> Hi; this fails to build on OSX and OpenBSD:
> >>>>
> >>>> UNXZ pc-bios/edk2-aarch64-code.fd.xz
> >>>> /bin/sh: xz: command not found
> >>
> >>
> >> I checked Travis builds for OSX. I suppose the Travis image has xz
> >> pulled/pre-installed and yours doesn't.
> >
> > Yeah, I expect I could install xz from homebrew here.
> >
> >> I used to check on OpenBSD until realizing you are the only one doing
> >> that. After having spent quite some time on it I removed it from my
> >> list, thus missed this failure. EDK2 doesn't build on OpenBSD but
> >> still this OS should be able to decompress the ROMs.
> >
> > At the moment I compile test it but don't 'make check' it
> > (ie I just use the tests/vm/openbsd setup).
> >
> > We could probably not unreasonably add 'xz' to the
> > build dependencies,
>
> I don't know how to do that, sorry. Are they tracked in some text file
> perhaps? (I.e. for a human reader?)
Adding something to the build deps means:
* checking that it is definitely available in all the host OSes
that we support (or that there is a fallback path where
configure detects that it is not present). We document the
principles of which OSes/distros this is in qemu-doc.texi --
I'm not sure if there's a wiki page or similar which gives
this in more concrete "version X of RHEL, version Y of SUSE"
etc terms
* ensuring that the images used for tests/vm (openbsd, netbsd,
freebsd) have it installed. I'm not sure exactly how this works
* checking that the various automated CI setups (travis, etc)
have it installed. I don't know exactly how to do this --
ask the people listed in MAINTAINERS under "Build and test
automation" (who should also know about the tests/vm stuff).
They will also know if various dockerfiles in tests/docker
need to be updated.
* flagging it up in the pull request email so I know I
might need to update the various machines where I do merge builds
* updating the section of the Changelog on the wiki where we
document build requirements once the change has gone into master
> Ultimately I don't know how to satisfy this requirement either -- let
> alone the OSX requirement, for which I can't even find a file under
> "tests/vm".
OSX in this case is one of the machines I deal with by
hand for doing merges. (Also Travis tests OSX.)
A question: does this absolutely have to be 'xz' and not bzip ?
thanks
-- PMM
- [Qemu-devel] [PULL 05/12] roms/edk2-funcs.sh: add the qemu_edk2_get_thread_count() function, (continued)
- [Qemu-devel] [PULL 05/12] roms/edk2-funcs.sh: add the qemu_edk2_get_thread_count() function, Philippe Mathieu-Daudé, 2019/03/16
- [Qemu-devel] [PULL 04/12] roms/edk2: advance to tag edk2-stable201903, Philippe Mathieu-Daudé, 2019/03/16
- [Qemu-devel] [PULL 03/12] tests/uefi-test-tools/build.sh: work around TianoCore#1607, Philippe Mathieu-Daudé, 2019/03/16
- [Qemu-devel] [PULL 01/12] roms: lift "edk2-funcs.sh" from "tests/uefi-test-tools/build.sh", Philippe Mathieu-Daudé, 2019/03/16
- [Qemu-devel] [PULL 02/12] roms/edk2-funcs.sh: require gcc-4.8+ for building i386 and x86_64, Philippe Mathieu-Daudé, 2019/03/16
- Re: [Qemu-devel] [PULL 00/12] EDK2 Firmware roms, Peter Maydell, 2019/03/17
- Re: [Qemu-devel] [PULL 00/12] EDK2 Firmware roms, Peter Maydell, 2019/03/17
- Re: [Qemu-devel] [PULL 00/12] EDK2 Firmware roms, Philippe Mathieu-Daudé, 2019/03/18
- Re: [Qemu-devel] [PULL 00/12] EDK2 Firmware roms, Peter Maydell, 2019/03/19
- Re: [Qemu-devel] [PULL 00/12] EDK2 Firmware roms, Laszlo Ersek, 2019/03/20
- Re: [Qemu-devel] [PULL 00/12] EDK2 Firmware roms,
Peter Maydell <=
- Re: [Qemu-devel] [PULL 00/12] EDK2 Firmware roms, Laszlo Ersek, 2019/03/20
- Re: [Qemu-devel] [PULL 00/12] EDK2 Firmware roms, Laszlo Ersek, 2019/03/20
- Re: [Qemu-devel] [PULL 00/12] EDK2 Firmware roms, Philippe Mathieu-Daudé, 2019/03/20
- Re: [Qemu-devel] [PULL 00/12] EDK2 Firmware roms, Philippe Mathieu-Daudé, 2019/03/20
- Re: [Qemu-devel] [PULL 00/12] EDK2 Firmware roms, Peter Maydell, 2019/03/21