Re: [Qemu-devel] [PATCH v3] hw/acpi: extract acpi_add_rom_blob()

[Igor Mammedov]

On Wed, 20 Mar 2019 08:37:14 +0800
Wei Yang <address@hidden> wrote:

> On Tue, Mar 19, 2019 at 10:00:38AM +0100, Igor Mammedov wrote:
> >On Tue, 19 Mar 2019 08:45:23 +0800
> >Wei Yang <address@hidden> wrote:
> >  
> >> On Mon, Mar 18, 2019 at 01:39:12PM +0100, Igor Mammedov wrote:  
> >> >On Fri, 15 Mar 2019 08:44:32 +0800
> >> >Wei Yang <address@hidden> wrote:
> >> >
> >> >in subject: s/extract/generalize/
> >> >    
> >> >> arm and i386 has almost the same function acpi_add_rom_blob(), except
> >> >> giving different FWCfgCallback function.
> >> >> 
> >> >> This patch extract acpi_add_rom_blob() to utils.c by passing    
> >> >             s/extract/moves/
> >> >    
> >> >> FWCfgCallback to it.
> >> >> 
> >> >> Signed-off-by: Wei Yang <address@hidden>    
> >> >
> >> >otherwise patch looks fine to me,
> >> >but checkpatch complains about comment style so that needs to be fixed as 
> >> >well
> >> >    
> >> 
> >> BTW, the checkpatch also says
> >> 
> >>     WARNING: added, moved or deleted file(s), does MAINTAINERS need 
> >> updating?
> >> 
> >> Do I need to fix this?  
> >yep, add me and Michael as maintainers for these new files.
> >  
> 
> It looks current statement already includes those files.
> 
> ACPI/SMBIOS
> M: Michael S. Tsirkin <address@hidden>
> M: Igor Mammedov <address@hidden>
> S: Supported
> F: include/hw/acpi/*
> F: hw/acpi/*

Agreed, checkpatch warning look like false positive, pls ignore it