Re: [Qemu-devel] [PATCH] mips-fulong2e: obey -vga none

[BALATON Zoltan]

On Tue, 19 Mar 2019, Paolo Bonzini wrote:
> Do not create an ATI VGA if "-vga none" was passed on the command line.
>
> Cc: BALATON Zoltan <address@hidden>

Thanks, I did not know about this variable. Although the real hardware has 
the GPU soldered on the mainboard it makes sense to allow it to be 
disabled in QEMU especially at this stage when Linux kernel has some 
problem with it so this is a good idea.

Reviewed-by: BALATON Zoltan <address@hidden>

When changing it you could also replace the -1 in pci_create with 
PCI_DEVFN(FULONG2E_ATI_SLOT, 0) to match the address the board has or 
should that be a separate patch?

Regards,
BALATON Zoltan

> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> hw/mips/mips_fulong2e.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e.c
> index 9d7480ed31..05a5a823a1 100644
> --- a/hw/mips/mips_fulong2e.c
> +++ b/hw/mips/mips_fulong2e.c
> @@ -349,10 +349,12 @@ static void mips_fulong2e_init(MachineState *machine)
>                                &smbus, &isa_bus);
>
>     /* GPU */
> -    dev = DEVICE(pci_create(pci_bus, -1, "ati-vga"));
> -    qdev_prop_set_uint32(dev, "vgamem_mb", 16);
> -    qdev_prop_set_uint16(dev, "x-device-id", 0x5159);
> -    qdev_init_nofail(dev);
> +    if (vga_interface_type != VGA_NONE) {
> +        dev = DEVICE(pci_create(pci_bus, -1, "ati-vga"));
> +        qdev_prop_set_uint32(dev, "vgamem_mb", 16);
> +        qdev_prop_set_uint16(dev, "x-device-id", 0x5159);
> +        qdev_init_nofail(dev);
> +    }
>
>     /* Populate SPD eeprom data */
>     spd_data = spd_data_generate(DDR, ram_size, &err);