[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] target/mips: Optimize ILVEV.<B|H|W|D> MSA i
|
From: |
Aleksandar Markovic |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] target/mips: Optimize ILVEV.<B|H|W|D> MSA instructions |
|
Date: |
Tue, 19 Mar 2019 13:55:32 +0000 |
> From: Mateja Marjanovic <address@hidden>
> Subject: [PATCH 2/2] target/mips: Optimize ILVEV.<B|H|W|D> MSA instructions
>
> ...
>
> +static inline void gen_ilvev_d(CPUMIPSState *env, uint32_t wd,
> + uint32_t ws, uint32_t wt)
> +{
> + tcg_gen_mov_i64(msa_wr_d[wd * 2], msa_wr_d[wt * 2]);
> + tcg_gen_mov_i64(msa_wr_d[wd * 2 + 1], msa_wr_d[ws * 2]);
> +}
> +
This code segment introduces a bug when wd == ws.
Please examine also the patch 1/2 for any similar behavior.
You should test these cases (wd == ws, wd == wt, etc.) too.
Aleksandar
>
> ...