[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] xen-mapcache: use MAP_FIXED flag so the mmap
|
From: |
Anthony PERARD |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] xen-mapcache: use MAP_FIXED flag so the mmap address hint is always honored |
|
Date: |
Mon, 18 Mar 2019 16:35:03 +0000 |
|
User-agent: |
Mutt/1.11.3 (2019-02-01) |
On Mon, Mar 18, 2019 at 03:48:59PM +0000, Igor Druzhinin wrote:
> On 18/03/2019 15:45, Roger Pau Monne wrote:
> > diff --git a/hw/i386/xen/xen-mapcache.c b/hw/i386/xen/xen-mapcache.c
> > index 349f72d00c..23de5517db 100644
> > --- a/hw/i386/xen/xen-mapcache.c
> > +++ b/hw/i386/xen/xen-mapcache.c
> > @@ -185,8 +185,13 @@ static void xen_remap_bucket(MapCacheEntry *entry,
> > }
> >
> > if (!dummy) {
> > + /*
> > + * If the caller has requested the mapping at a specific address
> > use
> > + * MAP_FIXED to make sure it's honored.
> > + */
>
> Since the comment now applied to both invocation - could it be moved
> outside the if statement then?
That sounds good to me.
--
Anthony PERARD