Re: [Qemu-devel] Issues around TYPE_INTERFACE

[Peter Maydell]

On Mon, 18 Mar 2019 at 13:17, Daniel P. Berrangé <address@hidden> wrote:
> On Mon, Mar 18, 2019 at 01:53:38PM +0100, Markus Armbruster wrote:
> > In case teaching it to checkpatch turns out to be too onerous: perhaps
> > certain things would be easier to check in a program that looks at
> > sources rather than patches.  Other projects have that as "make
> > syntax-check".
>
> FWIW, I think most of what qemu's checkpatch does would be better
> as checks against the source tree. The big pain with checkpatch
> is that it never enforces that we clean up existing code. So any
> time we introduce a new rule, it usually means that we end up having
> 2 different styles in the code forever.

The other big problem with checkpatch is that it's a huge perl
script that is doing fairly ad-hoc operations on textual source,
and certainly I find it almost impossible to understand to be
able to add any kind of new check to it.

If there was a good framework for writing project-specific static
syntax-and-style-checks that would be great; I don't know of one,
though.

thanks
-- PMM