[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: Silence Coverity in bdrv_drop_intermedia
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] block: Silence Coverity in bdrv_drop_intermediate() |
|
Date: |
Fri, 15 Mar 2019 14:43:58 +0000 |
On Fri, 15 Mar 2019 at 14:27, Kevin Wolf <address@hidden> wrote:
>
> Coverity doesn't like that the return value of bdrv_check_update_perm()
> stays unused only in this place (CID 1399710).
>
> Even if checking local_err should be equivalent to checking ret < 0,
> let's switch to using the return value to be more consistent (and in
> case of a bug somewhere down the call chain, forgetting to assign errp
> is more likely than returning 0 for an error case).
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM