[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v14 03/25] replay: disable default snapshot for reco
From: |
Pavel Dovgalyuk |
Subject: |
[Qemu-devel] [PATCH v14 03/25] replay: disable default snapshot for record/replay |
Date: |
Fri, 15 Mar 2019 15:08:35 +0300 |
User-agent: |
StGit/0.17.1-dirty |
From: Pavel Dovgalyuk <address@hidden>
This patch disables setting '-snapshot' option on by default
in record/replay mode. This is needed for creating vmstates in record
and replay modes.
Signed-off-by: Pavel Dovgalyuk <address@hidden>
Acked-by: Kevin Wolf <address@hidden>
---
vl.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index c1d5484e12..ace6230b05 100644
--- a/vl.c
+++ b/vl.c
@@ -1222,7 +1222,7 @@ static void configure_blockdev(BlockdevOptionsQueue
*bdo_queue,
qapi_free_BlockdevOptions(bdo->bdo);
g_free(bdo);
}
- if (snapshot || replay_mode != REPLAY_MODE_NONE) {
+ if (snapshot) {
qemu_opts_foreach(qemu_find_opts("drive"), drive_enable_snapshot,
NULL, NULL);
}
@@ -3179,7 +3179,13 @@ int main(int argc, char **argv, char **envp)
drive_add(IF_PFLASH, -1, optarg, PFLASH_OPTS);
break;
case QEMU_OPTION_snapshot:
- snapshot = 1;
+ {
+ Error *blocker = NULL;
+ snapshot = 1;
+ error_setg(&blocker, QERR_REPLAY_NOT_SUPPORTED,
+ "-snapshot");
+ replay_add_blocker(blocker);
+ }
break;
case QEMU_OPTION_numa:
opts = qemu_opts_parse_noisily(qemu_find_opts("numa"),
- [Qemu-devel] [PATCH v14 21/25] replay: document development rules, (continued)
- [Qemu-devel] [PATCH v14 21/25] replay: document development rules, Pavel Dovgalyuk, 2019/03/15
- [Qemu-devel] [PATCH v14 10/25] qapi: introduce replay.json for record/replay-related stuff, Pavel Dovgalyuk, 2019/03/15
- [Qemu-devel] [PATCH v14 09/25] replay: provide an accessor for rr filename, Pavel Dovgalyuk, 2019/03/15
- [Qemu-devel] [PATCH v14 18/25] replay: describe reverse debugging in docs/replay.txt, Pavel Dovgalyuk, 2019/03/15
- [Qemu-devel] [PATCH v14 15/25] replay: flush rr queue before loading the vmstate, Pavel Dovgalyuk, 2019/03/15
- [Qemu-devel] [PATCH v14 04/25] replay: update docs for record/replay with block devices, Pavel Dovgalyuk, 2019/03/15
- [Qemu-devel] [PATCH v14 11/25] replay: introduce info hmp/qmp command, Pavel Dovgalyuk, 2019/03/15
- [Qemu-devel] [PATCH v14 19/25] replay: add BH oneshot event for block layer, Pavel Dovgalyuk, 2019/03/15
- [Qemu-devel] [PATCH v14 01/25] replay: add missing fix for internal function, Pavel Dovgalyuk, 2019/03/15
- [Qemu-devel] [PATCH v14 24/25] replay: rename step-related variables and functions, Pavel Dovgalyuk, 2019/03/15
- [Qemu-devel] [PATCH v14 03/25] replay: disable default snapshot for record/replay,
Pavel Dovgalyuk <=
- [Qemu-devel] [PATCH v14 17/25] gdbstub: add reverse continue support in replay mode, Pavel Dovgalyuk, 2019/03/15
- [Qemu-devel] [PATCH v14 05/25] replay: don't drain/flush bdrv queue while RR is working, Pavel Dovgalyuk, 2019/03/15
- [Qemu-devel] [PATCH v14 16/25] gdbstub: add reverse step support in replay mode, Pavel Dovgalyuk, 2019/03/15
- [Qemu-devel] [PATCH v14 20/25] replay: init rtc after enabling the replay, Pavel Dovgalyuk, 2019/03/15
- [Qemu-devel] [PATCH v14 02/25] block: implement bdrv_snapshot_goto for blkreplay, Pavel Dovgalyuk, 2019/03/15
- [Qemu-devel] [PATCH v14 12/25] replay: introduce breakpoint at the specified step, Pavel Dovgalyuk, 2019/03/15
- [Qemu-devel] [PATCH v14 07/25] qcow2: introduce icount field for snapshots, Pavel Dovgalyuk, 2019/03/15
- [Qemu-devel] [PATCH v14 08/25] migration: introduce icount field for snapshots, Pavel Dovgalyuk, 2019/03/15
- Re: [Qemu-devel] [PATCH v14 00/25] Fixing record/replay and adding reverse debugging, no-reply, 2019/03/15