[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 08/23] ui/vnc: Use gcrypto_random_bytes for s
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 08/23] ui/vnc: Use gcrypto_random_bytes for start_auth_vnc |
|
Date: |
Fri, 15 Mar 2019 09:06:38 +0100 |
|
User-agent: |
NeoMutt/20180716 |
On Thu, Mar 14, 2019 at 08:26:14PM -0700, Richard Henderson wrote:
> Use a better interface for random numbers than rand().
> Fail gracefully if for some reason we cannot use the crypto system.
>
> Cc: Gerd Hoffmann <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> v2: Use qcrypto_random_bytes, not qemu_getrandom, as there is
> no need for deterministic results for this interface.
> v3: Fail gracefully in the event qcrypto_random_bytes fails.
Reviewed-by: Gerd Hoffmann <address@hidden>
- [Qemu-devel] [PATCH v3 00/23] Add qemu_getrandom and ARMv8.5-RNG etc, Richard Henderson, 2019/03/14
- [Qemu-devel] [PATCH v3 22/23] target/ppc: Use qemu_guest_getrandom for DARN, Richard Henderson, 2019/03/14
- [Qemu-devel] [PATCH v3 23/23] target/i386: Implement CPUID_EXT_RDRAND, Richard Henderson, 2019/03/14
- [Qemu-devel] [PATCH v3 19/23] hw/misc/exynos4210_rng: Use qemu_guest_getrandom, Richard Henderson, 2019/03/14
- [Qemu-devel] [PATCH v3 21/23] target/arm: Implement ARMv8.5-RNG, Richard Henderson, 2019/03/14
- [Qemu-devel] [PATCH v3 18/23] hw/misc/bcm2835_rng: Use qemu_guest_getrandom_nofail, Richard Henderson, 2019/03/14
- [Qemu-devel] [PATCH v3 13/23] linux-user: Use qemu_guest_getrandom_nofail for AT_RANDOM, Richard Henderson, 2019/03/14
- [Qemu-devel] [PATCH v3 20/23] target/arm: Put all PAC keys into a structure, Richard Henderson, 2019/03/14
- [Qemu-devel] [PATCH v3 08/23] ui/vnc: Use gcrypto_random_bytes for start_auth_vnc, Richard Henderson, 2019/03/14
- [Qemu-devel] [PATCH v3 04/23] crypto: Use O_CLOEXEC in qcrypto_random_init, Richard Henderson, 2019/03/14
- [Qemu-devel] [PATCH v3 02/23] crypto: Reverse code blocks in random-platform.c, Richard Henderson, 2019/03/14
- [Qemu-devel] [PATCH v3 16/23] aspeed/scu: Use qemu_guest_getrandom_nofail, Richard Henderson, 2019/03/14
- [Qemu-devel] [PATCH v3 14/23] linux-user/aarch64: Use qemu_guest_getrandom for PAUTH keys, Richard Henderson, 2019/03/14
- [Qemu-devel] [PATCH v3 11/23] linux-user: Initialize pseudo-random seeds for all guest cpus, Richard Henderson, 2019/03/14
- [Qemu-devel] [PATCH v3 07/23] ui/vnc: Split out authentication_failure, Richard Henderson, 2019/03/14