Re: [Qemu-devel] [PATCH 1/3] fix: buffer_length is ignored

[Martin Schrodt]

Hi,

On 3/15/19 8:43 AM, Gerd Hoffmann wrote:
>   Hi,
> 
>> -        qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, 46440);
>> +        qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, 
>> ppdo->buffer_length);
> 
> I'd just use
> 
>       ppdo->has_buffer_length ? ppdo->buffer_length : dev->timer_period * 4
> 
> here.
> 
> cheers,
>   Gerd
> 
> 

I made sure the value is present via the new function

static int qpa_validate_per_direction_opts()

That way, I can group the setting of all defaults in a single place,
which is cleaner from my perspective.

Wouldn't you agree?

cheers,
Martin