Re: [Qemu-devel] [PATCH 2/3] make latency configurable

[Eric Blake]

On 3/14/19 8:38 AM, Martin Schrodt wrote:
> Signed-off-by: Martin Schrodt <address@hidden>

The subject line says "what" (good) but doesn't state everything the
patch is doing (you are not only making it configurable, but you are
changing the default).  The commit body should say "why" (missing), and
mention all the related things being done to satisfy the "what". Some of
that information is already in your cover letter, and merely need to be
repeated here (the fact that the previous default of 10ms is too short,
but that 15ms worked for you).

> ---
>  audio/paaudio.c | 18 +++++++-----------
>  qapi/audio.json |  5 ++++-
>  2 files changed, 11 insertions(+), 12 deletions(-)
> 

> +++ b/qapi/audio.json
> @@ -206,12 +206,15 @@
>  #
>  # @name: name of the sink/source to use
>  #
> +# @latency: latency you want PulseAudio to archieve in microseconds

s/archieve/achieve/

> +#           (default 15000)
>  # Since: 4.0
>  ##
>  { 'struct': 'AudiodevPaPerDirectionOptions',
>    'base': 'AudiodevPerDirectionOptions',
>    'data': {
> -    '*name': 'str' } }
> +    '*name': 'str',
> +    '*latency': 'uint32' } }
>  
>  ##
>  # @AudiodevPaOptions:
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature