qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 6/7] linux-user: add IBT support to x86 safe-sys


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 6/7] linux-user: add IBT support to x86 safe-syscall.S
Date: Thu, 14 Mar 2019 11:37:36 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

On 14/03/19 00:52, Richard Henderson wrote:
> On 3/13/19 5:40 AM, Paolo Bonzini wrote:
>> Because safe-syscall.S does not go through the C compiler, the
>> .note.gnu.property note has to be added manually.  Safe syscalls do not
>> involve any indirect branch or stack unwinding, so they are trivially
>> safe for IBT or shadow stacks.
>>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>> ---
>>  linux-user/host/i386/safe-syscall.inc.S   | 19 +++++++++++++++++++
>>  linux-user/host/x86_64/safe-syscall.inc.S | 19 +++++++++++++++++++
>>  2 files changed, 38 insertions(+)
> 
> I suppose it's not worth trying to share these 19 lines...

They aren't exactly shared, one is .p2align 2, the other is .p2align 3.

Paolo

> Reviewed-by: Richard Henderson <address@hidden>
> 
> 
> r~
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]