Re: [Qemu-devel] [PATCH 3/4] hw/rdma: Use {} instead of {0}

[Kamal Heib]

On 3/13/19 2:25 PM, Eric Blake wrote:
> On 3/13/19 3:46 AM, Kamal Heib wrote:
>> Signed-off-by: Kamal Heib <address@hidden>
>> ---
>>  hw/rdma/rdma_backend.c      | 18 +++++++++---------
>>  hw/rdma/vmw/pvrdma_cmd.c    |  2 +-
>>  hw/rdma/vmw/pvrdma_qp_ops.c |  2 +-
>>  3 files changed, 11 insertions(+), 11 deletions(-)
> 
> {0} is standard C (but some versions of clang have a bug that it
> mistakenly warns for certain structs); {} is an extension (but one that
> both gcc and clang support).  Did you hit the actual clang bug that
> requires this change, or are you only doing it for consistency?
> 

I'm doing that for consistency, because some parts of the code already using {}
while other parts aren't, so this patch makes sure that all of them are aligned
to the same convention.