[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 08/12] vhost-user: add vhost_user_input_get_c
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH v6 08/12] vhost-user: add vhost_user_input_get_config() |
|
Date: |
Wed, 13 Mar 2019 07:26:14 +0100 |
|
User-agent: |
NeoMutt/20180716 |
> > And why host endianness? Everything else is little endian ...
>
> Hmm, I am not sure we correctly handle endianness in
> virtio_input_get_config(). virtio_input_add_config() do not use LE.
> Gerd, have you checked cross-endian scenarios?
Sure. BE ppc tcg guest on LE x86 host works fine.
All 16 and 32 bit fields in config space and protocol
messages are defined to be little endian. It's a pure
virtio-1.0 device after all ...
Note that all the fields virtio_input_get_config() and
virtio_input_add_config() are looking at are 8 bit.
cheers,
Gerd
- [Qemu-devel] [PATCH v6 02/12] vhost-user: define conventions for vhost-user backends, (continued)
- [Qemu-devel] [PATCH v6 02/12] vhost-user: define conventions for vhost-user backends, Marc-André Lureau, 2019/03/08
- [Qemu-devel] [PATCH v6 03/12] vhost-user: simplify vhost_user_init/vhost_user_cleanup, Marc-André Lureau, 2019/03/08
- [Qemu-devel] [PATCH v6 05/12] vhost-user: wrap some read/write with retry handling, Marc-André Lureau, 2019/03/08
- [Qemu-devel] [PATCH v6 04/12] libvhost-user: exit by default on VHOST_USER_NONE, Marc-André Lureau, 2019/03/08
- [Qemu-devel] [PATCH v6 06/12] Add vhost-user-backend, Marc-André Lureau, 2019/03/08
- [Qemu-devel] [PATCH v6 07/12] vhost-user: split vhost_user_read(), Marc-André Lureau, 2019/03/08
- [Qemu-devel] [PATCH v6 08/12] vhost-user: add vhost_user_input_get_config(), Marc-André Lureau, 2019/03/08
[Qemu-devel] [PATCH v6 09/12] libvhost-user-glib: export vug_source_new(), Marc-André Lureau, 2019/03/08
[Qemu-devel] [PATCH v6 11/12] Add vhost-user-input-pci, Marc-André Lureau, 2019/03/08
[Qemu-devel] [PATCH v6 12/12] contrib: add vhost-user-input, Marc-André Lureau, 2019/03/08
[Qemu-devel] [PATCH v6 10/12] libvhost-user: add vu_queue_unpop(), Marc-André Lureau, 2019/03/08