[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 2/9] qemu-binfmt-conf.sh: make opts -p and -c
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v7 2/9] qemu-binfmt-conf.sh: make opts -p and -c boolean |
Date: |
Tue, 12 Mar 2019 16:07:23 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 |
On 3/12/19 2:51 PM, Unai Martinez-Corral wrote:
> This patch breaks backward compatibility.
>
Is it worth a mention why we don't consider backwards-compatibility for
this script to be very important?
> Both '--persistent' and '--credential' default to 'no'. Hence, '-p no'
> or '-c no' are reduntant. Overall, accepting an argument might be
redundant
(Maintainer could fix up the typo without you needing to send v8, if the
only thing I find are minor like that)
> misleading because options are, indeed, boolean. This patch makes both
> options boolean in getopt, so if any of them is provided the corresponding
> variable is set to true.
>
> Signed-off-by: Unai Martinez-Corral <address@hidden>
> Reviewed-by: Laurent Vivier <address@hidden>
> ---
> scripts/qemu-binfmt-conf.sh | 16 +++++++---------
> 1 file changed, 7 insertions(+), 9 deletions(-)
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v7 6/9] qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX, (continued)
- [Qemu-devel] [PATCH v7 6/9] qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX, Unai Martinez-Corral, 2019/03/12
- [Qemu-devel] [PATCH v7 4/9] qemu-binfmt-conf.sh: use the same presentation format as for qemu-*, Unai Martinez-Corral, 2019/03/12
- [Qemu-devel] [PATCH v7 3/9] qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT, Unai Martinez-Corral, 2019/03/12
- [Qemu-devel] [PATCH v7 1/9] qemu-binfmt-conf.sh: enforce safe style consistency, Unai Martinez-Corral, 2019/03/12
- [Qemu-devel] [PATCH v7 5/9] qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options, Unai Martinez-Corral, 2019/03/12
- [Qemu-devel] [PATCH v7 2/9] qemu-binfmt-conf.sh: make opts -p and -c boolean, Unai Martinez-Corral, 2019/03/12
- Re: [Qemu-devel] [PATCH v7 2/9] qemu-binfmt-conf.sh: make opts -p and -c boolean,
Eric Blake <=
Re: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh, no-reply, 2019/03/12
Re: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh, no-reply, 2019/03/12
Re: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh, no-reply, 2019/03/12
Re: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh, no-reply, 2019/03/12
Re: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh, no-reply, 2019/03/12
Re: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh, no-reply, 2019/03/12
Re: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh, no-reply, 2019/03/12