Re: [Qemu-devel] [PATCH 2/4] test-bdrv-graph-mod: fix Error leak

[Eric Blake]

On 3/12/19 9:13 AM, Paolo Bonzini wrote:
> Reported by ASAN.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  tests/test-bdrv-graph-mod.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/test-bdrv-graph-mod.c b/tests/test-bdrv-graph-mod.c
> index 458dfa6661..283dc84869 100644
> --- a/tests/test-bdrv-graph-mod.c
> +++ b/tests/test-bdrv-graph-mod.c
> @@ -114,6 +114,7 @@ static void test_update_perm_tree(void)
>      bdrv_append(filter, bs, &local_err);
>  
>      g_assert_nonnull(local_err);
> +    error_free(local_err);

Better would be using error_free_or_abort(&local_err) instead of these
two lines.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature