Re: [Qemu-devel] [PULL 0/4] qtest and misc patches

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL 0/4] qtest and misc patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
fe3629e622 scripts/qemugdb: re-license timers.py to GPLv2 or later
e0ee3d52c9 hw/sd/sdhci: Move PCI-related code into a separate file
87fcefd5ed ahci-test: Drop dependence on global_qtest
3c1dda5ace tests: test-announce-self: fix memory leak

=== OUTPUT BEGIN ===
1/4 Checking commit 3c1dda5aceb9 (tests: test-announce-self: fix memory leak)
2/4 Checking commit 87fcefd5edf2 (ahci-test: Drop dependence on global_qtest)
3/4 Checking commit e0ee3d52c944 (hw/sd/sdhci: Move PCI-related code into a 
separate file)
ERROR: Macros with complex values should be enclosed in parenthesis
#76: FILE: hw/sd/sdhci-internal.h:326:
+#define DEFINE_SDHCI_COMMON_PROPERTIES(_state) \
+    DEFINE_PROP_UINT8("sd-spec-version", _state, sd_spec_version, 2), \
+    DEFINE_PROP_UINT8("uhs", _state, uhs_mode, UHS_NOT_SUPPORTED), \
+    \
+    /* Capabilities registers provide information on supported

WARNING: Block comments use a leading /* on a separate line
#80: FILE: hw/sd/sdhci-internal.h:330:
+    /* Capabilities registers provide information on supported

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#93: 
new file mode 100644

total: 1 errors, 2 warnings, 290 lines checked

Patch 3/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/4 Checking commit fe3629e62258 (scripts/qemugdb: re-license timers.py to 
GPLv2 or later)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden