[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qom: use object_new_with_type in object_new_wit
|
From: |
Stefano Garzarella |
|
Subject: |
Re: [Qemu-devel] [PATCH] qom: use object_new_with_type in object_new_with_propv |
|
Date: |
Tue, 12 Mar 2019 09:43:13 +0100 |
|
User-agent: |
NeoMutt/20180716 |
On Mon, Mar 11, 2019 at 04:32:34PM +0800, Wei Yang wrote:
> Function object_new_with_propv already get the Type of the object, so we
> could leverage object_new_with_type here.
>
> [make check test pass]
>
> Signed-off-by: Wei Yang <address@hidden>
> ---
> qom/object.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
LGTM. Just a note for future patches:
I think that info like "[make check test pass]" should go after the
three dashes to avoid to store it in the commit message.
Reviewed-by: Stefano Garzarella <address@hidden>
Thanks,
Stefano