[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/8] tests/virtio-blk-test: Disable auto-read-on
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/8] tests/virtio-blk-test: Disable auto-read-only |
Date: |
Mon, 11 Mar 2019 21:46:17 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 |
On 3/8/19 9:37 AM, Kevin Wolf wrote:
> tests/virtio-blk-test uses a temporary image file that it deletes while
> QEMU is still running, so it can't be reopened when writers are
> attached or detached. Disable auto-read-only to keep it always writable.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> tests/virtio-blk-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/tests/virtio-blk-test.c b/tests/virtio-blk-test.c
> index 8d2fc9c710..0e464aeea4 100644
> --- a/tests/virtio-blk-test.c
> +++ b/tests/virtio-blk-test.c
> @@ -72,7 +72,7 @@ static QOSState *pci_test_start(void)
> QOSState *qs;
> const char *arch = qtest_get_arch();
> char *tmp_path;
> - const char *cmd = "-drive if=none,id=drive0,file=%s,format=raw "
> + const char *cmd = "-drive
> if=none,id=drive0,file=%s,format=raw,auto-read-only=off "
> "-drive if=none,id=drive1,file=null-co://,format=raw "
> "-device virtio-blk-pci,id=drv0,drive=drive0,"
> "addr=%x.%x";
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/8] file-posix: Make auto-read-only dynamic, Kevin Wolf, 2019/03/08
- [Qemu-devel] [PATCH 2/8] block: Avoid useless local_err, Kevin Wolf, 2019/03/08
- [Qemu-devel] [PATCH 1/8] tests/virtio-blk-test: Disable auto-read-only, Kevin Wolf, 2019/03/08
- Re: [Qemu-devel] [PATCH 1/8] tests/virtio-blk-test: Disable auto-read-only,
Eric Blake <=
- [Qemu-devel] [PATCH 3/8] block: Make permission changes in reopen less wrong, Kevin Wolf, 2019/03/08
- [Qemu-devel] [PATCH 4/8] file-posix: Factor out raw_reconfigure_getfd(), Kevin Wolf, 2019/03/08
- [Qemu-devel] [PATCH 6/8] file-posix: Lock new fd in raw_reopen_prepare(), Kevin Wolf, 2019/03/08
- [Qemu-devel] [PATCH 5/8] file-posix: Store BDRVRawState.reopen_state during reopen, Kevin Wolf, 2019/03/08
- [Qemu-devel] [PATCH 7/8] file-posix: Prepare permission code for fd switching, Kevin Wolf, 2019/03/08
- [Qemu-devel] [PATCH 8/8] file-posix: Make auto-read-only dynamic, Kevin Wolf, 2019/03/08
- Re: [Qemu-devel] [PATCH 0/8] file-posix: Make auto-read-only dynamic, Peter Krempa, 2019/03/11